Omit severity for removing the warning from prettier

[Schniz]

Hey! Thanks for this package 😸

Right now, all options are passed automatically right from the stylelint-prettier rule into prettier itself.
That causes a warning if you pass something that is related to stylelint only, like severity, So the following line actually raises a warning:

{
  "rules": {
    "prettier/prettier": [true, { "severity": "warning" }]
  }
}

This warning can be avoided, so this PR fixes it by omitting severity. Figuring out which keys should be allowed may be problematic if Prettier will change its API, but I guess that severity is something that won't be there anyway because it's not a linter.

What do you think?

😸

[BPScott]

Thanks for spotting this.

In retrospect, What I really should have is done is have the prettierrc config as a key in those secondary options, rather than treating the whole block as options to pass to prettier. As it currently stands I've backed myself into a corner and made it impossible to add additional options, along with causing the headache having to extract out the built-in options you've spotted.
changing

Changing the config like below is easily fixable but will review a major version bump as it'll be a breaking change.

Current (problematic as it requires extracting severity and message from the prettier options):

"prettier/prettier": [true, { 
  "severity": "warning",
  "singleQuotes": true
}]

Future (better as you don't need to extract their builtins):

"prettier/prettier": [true, {
  "severity": "warning",
  prettierOptions: {"singleQuotes": true}
}]

---

In the mean time lets go with your solution of extracting out those common options. I've got a few requested changes:

• It looks like in addition to severity, message is also a built-in option according to https://stylelint.io/user-guide/configuration/#severities-error--warning. We should cover that too. This suggests they're the only extra values that get tossed into the secondary options

• Can you add a test case showing that you get no warnings if you specify a custom severity and message.

• I think we can do this in a terser way by using rest operators. Try replacing https://github.com/prettier/stylelint-prettier/pull/10/files#diff-138c8a16d536ccc62562c983573ece99L23 with:

  (expectation, {severity, message, ...stylelintPrettierOptions}, context) => {
  

  I think that will extract out the two built-in values without needing your function.

[Schniz]

Hi! thanks for the reply 😸

In retrospect, What I really should have is done is have the prettierrc config as a key in those secondary options, rather than treating the whole block as options to pass to prettier. As it currently stands I've backed myself into a corner and made it impossible to add additional options, along with causing the headache having to extract out the built-in options you've spotted.

You're right. Sounds better 👍
I guess that I'd rather just fix this small issue so it won't bother my build 😸
I can later on add a PR that makes this change too - if you want

... message is also a built-in option ...

Right. I'll fix that too 😸

• Can you add a test case showing that you get no warnings if you specify a custom severity and message.

Sure, my bad that it wasn't there in the first place 👍

... we can do this in a terser way by using rest operators ...

Yup. That was the first thing I tried, but unfortunately the engine.node key in package.json suggests Node 6 and above, and unfortunately, Node 6 doesn't support object spread natively:

stylelint-prettier/package.json

Lines 47 to 49 in 0782dce

	"engines": {
	"node": ">=6"
	},

This can be changed as well, but probably should be considered as a breaking change too

[Schniz]

no native async await in Node 6 as well 🤕

[BPScott]

Thanks again @Schniz. I've published this as v1.0.4.