Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON/GraphQL parser (prettier 1.5) #17

Merged
merged 4 commits into from Jun 30, 2017

Conversation

vutran
Copy link
Contributor

@vutran vutran commented Jun 22, 2017

This PR adds the json option as an option for the parser configuration (originally from #16 but extracted as a separate PR as a release with the json parser hasn't landed on npm yet.

TODO:

  • bump prettier version on package.json
  • test locally: command, autoformat, etc.

@mitermayer
Copy link
Member

mitermayer commented Jun 27, 2017

prettier 1.5 has been released, we should now be able to amend this PR!

@mitermayer
Copy link
Member

Hi @vutran please let me know if there is anything i can do here to help on the remainder checks

@vutran
Copy link
Contributor Author

vutran commented Jun 29, 2017

@mitermayer I'll be looking at this tonight.

@vutran vutran changed the title Add JSON parser Add JSON/GraphQL parser (prettier 1.5) Jun 30, 2017
@vutran
Copy link
Contributor Author

vutran commented Jun 30, 2017

@mitermayer Should be good to go. I've added the option for the new GraphQL parser as well.

@mitermayer
Copy link
Member

Awesome! merging this now, will do a new release either tonight or tomorrow! Thanks a lot for your contribution!

@mitermayer mitermayer merged commit 88458c2 into prettier:master Jun 30, 2017
@vutran vutran deleted the add-json-parser branch June 30, 2017 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants