Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Incorrect script update logic #7

Closed
click0 opened this issue Jan 26, 2019 · 1 comment
Closed

Bug: Incorrect script update logic #7

click0 opened this issue Jan 26, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@click0
Copy link
Contributor

click0 commented Jan 26, 2019

Expected Behavior

We expect that users of the script will see minor updates, including security fixes.

Actual Behavior

If there are minor updates without release, then users of these minor updates will not see the regular means. Including the last version of the script - 0.3.1.

Therefore it is necessary to do these minor updates as releases.

I also pay attention that deleting old files is not entirely correct, all of a sudden, something goes wrong and the user will receive a "broken" script.
I suggest renaming old files and directories, for example:
mv $JINX_BIN $JINX_BIN.back.$JINX_VERSION
and
mv $JINX_ETC $JINX_ETC.back.$JINX_VERSION

Steps to Reproduce the Problem

Specifications

  • jinx version:
  • OS and version:
  • nginx version:
@pretzelhands pretzelhands self-assigned this Jan 28, 2019
@pretzelhands pretzelhands added the bug Something isn't working label Jan 28, 2019
@pretzelhands
Copy link
Owner

Updating now makes backups of older versions instead of just deleting it. Will be released with the upcoming 0.3.1 release. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants