Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gitignore do not run autocrlf #145

Merged
merged 1 commit into from Apr 7, 2020
Merged

fix: gitignore do not run autocrlf #145

merged 1 commit into from Apr 7, 2020

Conversation

tsuyoshicho
Copy link
Contributor

@tsuyoshicho tsuyoshicho commented Mar 13, 2020 •
edited

When autocrlf off/linux checkout, file modification detect by git

Reason:
gitignore has mac icon define,that is

# Icon must end with two \r
Icon^M

Then git mis-detect CRLF/LF

@tsuyoshicho
Copy link
Contributor Author

ping @mattn

Sorry, it's been a long time from PRed, but could you review?

@mattn
Copy link
Member

mattn commented Apr 7, 2020

Ooops. Sorry.

@mattn mattn merged commit e42063e into previm:master Apr 7, 2020
@mattn
Copy link
Member

mattn commented Apr 7, 2020

Thank you

@tsuyoshicho
Copy link
Contributor Author

Thank you too.

@tsuyoshicho tsuyoshicho deleted the fix/gitignore branch April 7, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsuyoshicho @mattn