fix: make parentId param optional in actions.add()

prevwong · May 13, 2024 · b16aa5f · b16aa5f
1 parent 438f48f
commit b16aa5f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/.changeset/sixty-rice-build.md b/.changeset/sixty-rice-build.md
@@ -0,0 +1,5 @@
+---
+'@craftjs/core': patch
+---
+
+Make parentId param optional in actions.add()
diff --git a/packages/core/src/editor/actions.ts b/packages/core/src/editor/actions.ts
@@ -38,7 +38,7 @@ const Methods = (
   /** Helper functions */
   const addNodeTreeToParent = (
     tree: NodeTree,
-    parentId?: NodeId,
+    parentId: NodeId,
     addNodeType?:
       | {
           type: 'child';
@@ -84,15 +84,6 @@ const Methods = (
 
     iterateChildren(tree.rootNodeId, parentId);
 
-    if (!parentId) {
-      invariant(
-        tree.rootNodeId === ROOT_NODE,
-        'Cannot add non-root Node without a parent'
-      );
-
-      return;
-    }
-
     const parent = getParentAndValidate(parentId);
 
     if (addNodeType.type === 'child') {
@@ -180,7 +171,7 @@ const Methods = (
      * @param parentId
      * @param index
      */
-    add(nodeToAdd: Node | Node[], parentId: NodeId, index?: number) {
+    add(nodeToAdd: Node | Node[], parentId?: NodeId, index?: number) {
       // TODO: Deprecate adding array of Nodes to keep implementation simpler
       let nodes = [nodeToAdd];
       if (Array.isArray(nodeToAdd)) {
@@ -197,7 +188,7 @@ const Methods = (
             },
             rootNodeId: node.id,
           },
-          parentId,
+          parentId ?? ROOT_NODE,
           { type: 'child', index }
         );
       });