-
-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v0.3.x): allow custom EditorStore #398
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0aa644b
to
0c94bdd
Compare
✅ Deploy Preview for craftjs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
prevwong
added a commit
that referenced
this pull request
May 13, 2024
commit f1626274fdc9e4abba82559f2922452df4d95cc8 Author: Prev Wong <prevwong@gmail.com> Date: Fri Apr 7 12:29:44 2023 +0800 chore: sync with stable commit 57f9f8c Author: Prev Wong <prevwong@gmail.com> Date: Mon Mar 28 20:39:54 2022 +0800 v0.3.0-alpha.4 commit ba76ba7 Author: Prev Wong <prevwong@gmail.com> Date: Mon Mar 28 20:36:21 2022 +0800 feat: add history event listener (#399) commit 61260ac Author: Prev Wong <prevwong@gmail.com> Date: Mon Mar 28 20:36:02 2022 +0800 feat: create custom EditorStore (#398) commit 9bd30ee Author: Prev Wong <prevwong@gmail.com> Date: Wed Mar 16 23:12:43 2022 +0800 feat: add carbonads snippet commit 158ef09 Author: Prev Wong <prevwong@gmail.com> Date: Mon Mar 7 23:47:19 2022 +0800 chore(layers): update URLs commit 0f0ac47 Author: Prev Wong <prevwong@gmail.com> Date: Mon Mar 7 23:45:04 2022 +0800 chore: update README url commit 82cb263 Author: Prev Wong <prevwong@gmail.com> Date: Mon Mar 7 23:21:21 2022 +0800 chore: pin docs dependencies commit 562f4a6 Author: Prev Wong <prevwong@gmail.com> Date: Mon Mar 7 22:01:37 2022 +0800 chore: update docs api key commit f15a832 Author: Kaiwei Yang <kaiwei@spacebib.com> Date: Mon Mar 7 21:50:56 2022 +0800 fix: remove redundant "}" of the image url (#372) # Conflicts: # site/src/components/Image.js commit e1ffaee Author: Kyℓe Hensel <k-yle@users.noreply.github.com> Date: Tue Mar 8 02:49:46 2022 +1300 fix: syntax error in README example (#375) commit 780f29e Author: Artur Drobinskiy <artur.regs@gmail.com> Date: Fri Feb 11 00:29:46 2022 +0700 chore: fix URLs in README (#369) commit 51c3f35 Author: Prev Wong <prevwong@gmail.com> Date: Tue Jan 11 16:18:21 2022 +0800 chore: cleanup workflows commit 005a83f Author: Prev Wong <prevwong@gmail.com> Date: Tue Jan 11 16:16:17 2022 +0800 chore: remove build badge commit f6d3849 Author: Prev Wong <prevwong@gmail.com> Date: Tue Jan 11 16:10:07 2022 +0800 v0.3.0-alpha.3 commit 2b07b91 Author: Prev Wong <prevwong@gmail.com> Date: Tue Jan 11 15:52:04 2022 +0800 chore(layers): add react-contenteditable as dep (#364) commit 69678ab Author: Prev Wong <prevwong@gmail.com> Date: Mon Jan 10 21:35:59 2022 +0800 chore: allow react 17 as peer dep (#361) commit 1d7c362 Author: Prev Wong <prevwong@gmail.com> Date: Tue Jan 11 15:42:38 2022 +0800 chore(layers@0.3.x): craft core peer dep (#362) commit fb14828 Author: Prev Wong <prevwong@gmail.com> Date: Mon Dec 13 21:40:01 2021 +0800 v0.3.0-alpha.2 commit c6f3c3f Author: Prev Wong <prevwong@gmail.com> Date: Mon Dec 13 21:35:24 2021 +0800 fix: linked nodes history (#353) commit d7ee28c Author: Prev Wong <prevwong@gmail.com> Date: Mon Dec 13 21:22:36 2021 +0800 fix: try catch collector values (#352) commit 0da49ec Author: Prev Wong <prevwong@gmail.com> Date: Mon Dec 13 21:22:10 2021 +0800 fix: normalize state call (#351) commit 2081ac6 Author: Prev Wong <prevwong@gmail.com> Date: Wed Nov 17 22:25:06 2021 +0800 v0.3.0-alpha.1 commit c60e402 Author: Prev Wong <prevwong@gmail.com> Date: Wed Nov 17 22:22:38 2021 +0800 fix: backwards compatibility bugs (#345) * fix: backwards compatibility bugs * fix: types commit b9c883e Author: Prev Wong <prevwong@gmail.com> Date: Tue Nov 16 23:10:12 2021 +0800 v0.3.0-alpha.0 commit 9e68dea Author: Prev Wong <prevwong@gmail.com> Date: Tue Nov 16 23:04:41 2021 +0800 chore: add release command commit 47725a7 Author: Prev Wong <prevwong@gmail.com> Date: Tue Nov 16 22:54:13 2021 +0800 chore: rename script commit f6a8ae6 Author: Prev Wong <prevwong@gmail.com> Date: Tue Nov 16 22:47:02 2021 +0800 chore: reuse existing actions commit 14ee0dd Author: Prev Wong <prevwong@gmail.com> Date: Tue Nov 16 22:46:03 2021 +0800 chore: cleanup commit c80dd95 Author: Prev Wong <prevwong@gmail.com> Date: Tue Nov 16 22:45:36 2021 +0800 feat: backwards compatible parseReactElement commit ddf9a0f Author: Prev Wong <prevwong@gmail.com> Date: Tue Nov 16 20:49:48 2021 +0800 feat: move resolver out of state commit 9c5f5da Author: Prev Wong <prevwong@gmail.com> Date: Tue Nov 16 15:04:56 2021 +0800 feat: backwards-compatible node tree commit 1aeeb39 Author: Prev Wong <prevwong@gmail.com> Date: Mon Nov 15 19:03:36 2021 +0800 chore: update publish script commit 3fbcf4a Author: hariombalhara <hariombalhara@gmail.com> Date: Mon Nov 15 16:12:10 2021 +0530 fix(docs): basic example paths and command (#327) `npm dev` command doesn't exist now `basic` folder location has changed. So fix it according to that. commit 502b865 Author: Prev Wong <prevwong@gmail.com> Date: Mon Nov 15 17:25:53 2021 +0800 chore: update scripts commit 48b6fe4 Author: Prev Wong <prevwong@gmail.com> Date: Mon Nov 15 16:14:08 2021 +0800 fix: linked node hydration commit 1187d35 Author: Prev Wong <prevwong@gmail.com> Date: Fri Nov 12 21:09:01 2021 +0800 chore: simplify store types commit e71dc96 Author: Prev Wong <prevwong@gmail.com> Date: Fri Nov 12 20:02:49 2021 +0800 feat: move resolver to EditorState commit fe618f1 Author: Prev Wong <prevwong@gmail.com> Date: Thu Nov 11 22:52:02 2021 +0800 fix: test commit 16568ef Author: Prev Wong <prevwong@gmail.com> Date: Thu Nov 11 21:56:11 2021 +0800 feat: add temp replaceResolver method commit 570709d Author: Prev Wong <prevwong@gmail.com> Date: Thu Nov 11 21:55:24 2021 +0800 chore: fix context commit a24efaf Author: Prev Wong <prevwong@gmail.com> Date: Thu Nov 11 21:54:58 2021 +0800 feat: fix resolver priority commit cd8b3d9 Merge: b9f6406 f5b1bd4 Author: Prev Wong <prevwong@gmail.com> Date: Thu Nov 11 19:49:29 2021 +0800 Merge branch 'state-v2' into merge-state-v2 # Conflicts: # packages/core/src/editor/Editor.tsx # packages/core/src/editor/EditorContext.tsx # packages/core/src/editor/actions.ts # packages/core/src/editor/query.tsx # packages/core/src/editor/useInternalEditor.ts # packages/core/src/events/DefaultEventHandlers.ts # packages/core/src/events/Events.tsx # packages/core/src/events/findPosition.ts # packages/core/src/hooks/useNode.ts # packages/core/src/interfaces/editor.ts # packages/core/src/interfaces/events.ts # packages/core/src/nodes/NodeContext.tsx # packages/core/src/nodes/useInternalNode.ts # packages/core/src/utils/createNode.ts # packages/core/src/utils/resolveComponent.ts # packages/layers/src/events/index.tsx # packages/layers/src/layers/LayerContextProvider.tsx # packages/layers/src/manager/useLayerManager.tsx # packages/utils/src/index.ts # packages/utils/src/useMethods.ts commit f5b1bd4 Author: Prev Wong <prevwong@gmail.com> Date: Tue Jul 27 00:51:46 2021 +0800 feat: simplify EditorState (#272) * feat: simplify EditorState * fix: tests * chore: cleanup * chore: cleanup * chore: move experimental packages * fix: handlers * fix: type * fix: event types * chore: cleanup * chore: feedback commit 234c74c Author: Prev Wong <prevwong@gmail.com> Date: Wed Jun 30 23:33:34 2021 +0800 feat: refactor editor store (#259) * chore: update tests * feat: add simpler store implementation * chore: rename store -> EditorStore * feat: use updated store implementation * chore: cleanup * fix: backwards compatibility * chore: unsubscribe * fix(example): renderer dom not found * fix(layers): memoize component * chore: cleanup * feat: memoize Editor component * fix: ts * feat: move options out of state * chore: lint * fix: ts * chore: cleanup # Conflicts: # packages/layers/src/manager/useLayerManager.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to pass a custom
EditorStore
when initialising Craft:This is useful when you need the
EditorStore
beforehand outside a React context. Otherwise, you would need to first set up the<Editor />
component and access the store viauseEditor()
.