Refactor Event Handling #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename EventManager => Events expose useEventHandler
|
Hi @prevwong will you include #35 and #37 in your refactor solution? Then I'll close them in favor of your solution here. Otherwise I'll try to find some time asap to merge #35 - on #37 I would need your feedback to continue. If you're not in a hurry - would now be a good time to add some tests? Maybe some cypress integration tests? |
|
@ankri Let's keep those in a separate PR. Yeah, will be adding tests with Cypress but I will need some time for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to Improve on the overall structure of how events are handled in Craft.
useHandlerGuardanduseConnectorHooks.DerivedEventHandlerswhich makes it easier to bootstrap new handlers/connectors.