fix: error when evaluating falsey condition in a repeated template (#149

)
prevwong · Mar 8, 2024 · 378baff · 378baff
1 parent af6f9e4
commit 378baff
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/.changeset/fast-singers-accept.md b/.changeset/fast-singers-accept.md
@@ -0,0 +1,5 @@
+---
+'@rekajs/core': patch
+---
+
+Ignore nullish value when evaluating repeated templates
diff --git a/packages/core/src/each.ts b/packages/core/src/each.ts
@@ -96,7 +96,15 @@ export class EachDirectiveEvaluator {
 
             newItems.add(itemHash);
 
-            views[i] = this.computeIteratorItem(itemHash, value, i);
+            const item = this.computeIteratorItem(itemHash, value, i);
+
+            // Ensure we don't return a null/undefined value
+            // This can happen if the template has an `if` condition which returns false
+            if (!item) {
+              continue;
+            }
+
+            views[i] = item;
           }
         }