fix psalm errors (#11)

* fix phpdoc type of $pass You have to specify the type of the value * Specify psalm type of Option::fromKey()'s $key argument * none: return new instances instead of returning $this phpdoc say it should return a Option<U>, but $this is of type Option<T>, so psalm detect this as a type mismatch
prewk · Mar 24, 2021 · fa938d7 · fa938d7
1 parent e060cfe
commit fa938d7
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 21 deletions.
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -1,21 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <files psalm-version="4.6.4@97fe86c4e158b5a57c5150aa5055c38b5a809aab">
-  <file src="src/Option.php">
-    <MixedArgument occurrences="1">
-      <code>$key</code>
-    </MixedArgument>
-  </file>
   <file src="src/Option/None.php">
-    <InvalidReturnStatement occurrences="3">
-      <code>$this</code>
-      <code>$this</code>
-      <code>$this</code>
-    </InvalidReturnStatement>
-    <InvalidReturnType occurrences="3">
-      <code>Option&lt;U&gt;</code>
-      <code>Option&lt;U&gt;</code>
-      <code>Option&lt;U&gt;</code>
-    </InvalidReturnType>
     <MixedArgument occurrences="2">
       <code>$this-&gt;pass</code>
       <code>$this-&gt;pass</code>

diff --git a/spec/Option/NoneSpec.php b/spec/Option/NoneSpec.php
@@ -51,7 +51,7 @@ function it_unwrapOrElses()
 
     function it_doesnt_map()
     {
-        $this->map(function() {})->shouldBe($this);
+        $this->map(function() {})->shouldHaveType(None::class);
     }
 
     function it_mapOrs()

diff --git a/src/Option.php b/src/Option.php
@@ -223,6 +223,7 @@ public static function fromNullable($thing): Option
      *
      * @param array $coll C
      * @param mixed $key
+     * @psalm-param array-key $key
      * @return Option Option<V>
      */
     public static function fromKey(array $coll, $key): Option

diff --git a/src/Option/None.php b/src/Option/None.php
@@ -28,13 +28,14 @@ class None extends Option
 {
     /**
      * @var array
+     * @psalm-var list<mixed>
      */
     private $pass;
 
     /**
      * None constructor
      *
-     * @param array ...$pass
+     * @param mixed ...$pass
      */
     public function __construct(...$pass) {
         $this->pass = $pass;
@@ -123,7 +124,7 @@ public function unwrapOrElse(Closure $op)
      */
     public function map(Closure $mapper): Option
     {
-        return $this;
+        return new self(...$this->pass);
     }
 
     /**
@@ -184,7 +185,7 @@ public function iter(): array
      */
     public function and(Option $optb): Option
     {
-        return $this;
+        return new self(...$this->pass);
     }
 
     /**
@@ -200,7 +201,7 @@ public function and(Option $optb): Option
      */
     public function andThen(Closure $op): Option
     {
-        return $this;
+        return new self(...$this->pass);
     }
 
     /**

diff --git a/src/Option/Some.php b/src/Option/Some.php
@@ -34,6 +34,7 @@ class Some extends Option
 
     /**
      * @var array
+     * @psalm-var list<mixed>
      */
     private $pass;
 
@@ -42,7 +43,7 @@ class Some extends Option
      *
      * @param mixed $value
      * @psalm-param T $value
-     * @param array ...$pass
+     * @param mixed ...$pass
      */
     public function __construct($value, ...$pass)
     {