Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop phpdoc template parameter as it cannot be not used #6

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Drop phpdoc template parameter as it cannot be not used #6

merged 1 commit into from
Jan 10, 2020

Conversation

andrew-demb
Copy link
Contributor

Psalm doesn't provide support use it in something like @psalm-throws

Fixes #5

@andrew-demb
Drop phpdoc template parameter as it cannot be not used (psalm doesn'…
a5ee93d 
…t provide support use it in something like `@psalm-throws`)

Fixes prewk#5
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a5ee93d on andrew-demb:drop-expect-template-phpdoc into e97853c on prewk:master.

@prewk
Copy link
Owner

prewk commented Jan 10, 2020

Wow, you're fast!

@prewk prewk merged commit 9972ee0 into prewk:master Jan 10, 2020
@andrew-demb andrew-demb deleted the drop-expect-template-phpdoc branch January 10, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option::expect doesn't pass psalm analysis
3 participants
@andrew-demb @coveralls @prewk