get_wifi_info() does not attempt to activate wifi - Mac OS 10.6

[drewreece]

The get_wifi_info function (in platform/mac/functions) either returns information from the scanner utility - (/System/Library/PrivateFrameworks/Apple80211.framework/Versions/Current/Resources/airport -I)
or it returns nothing for the $wifi_points variable. The geo module uses $wifi_points to get the location, but if $wifi_points is empty it makes no attempt to activate wifi.

Wouldn't it make sense to turn airport on if the scanner returns an 'Off' status? Then recheck the status & only return an empty value for $wifi_points if that scan fails.

[drewreece]

Changing the function get_wifi_info() to enable wifi if it is off seems to fix it ...
but it does result in the wifi state changing permanently & potentially could alert the user.
If the state is turned back off it breaks the ability to get the access point scan data for the geo module. get_wifi_access_points() (modules/geo/functions) will also use the airport command but the wifi card will be in its disabled state.

I think prey should detect the wifi state and then return it to this state after completing any scans etc.

Here is my changed function.

get_wifi_info() {
wifi_info=$airport -I | grep -v "Off"
if [ -n $wifi_info ]; then
# Turn on wifi
networksetup -setairportpower Airport on 2>/dev/null
wifi_info=$airport -I | grep -v "Off"
fi
}

[drewreece]

Added to my fork…
http://github.com/drewreece/prey

…but I'm too stupid to add a commit message !

[tomas]

Merged! Closing...

[drewreece]

Sorry Tomas, you need to pull again, I reviewed it and it broke. There were too many arguments for the if statement and the test for nonzero (-n) was backwards, it needs to be a test for zero (-z).

Sorry

[tomas]

I believe we're done with this (on 0.4.4), are we not?

[drewreece]

This is in 0.4.4 but I tried testing on a new install of OSX & I couldn't get a connection to work when my access point was set to no security. I think I need to create a new access point & run some more tests.

[tomas]

Any news drew? We're about to pack a new release so it would be great to make sure this bug is out.

[drewreece]

Tomas,
The -n test fails to activate the wifi (when connected via ethernet) for an access point scan. If the test is -z the wifi will be activated.

The 0.4.4 release is correct with the -z test.

Cheers,
Drew