Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NFCIP support (NDEF) #10

Closed
GoogleCodeExporter opened this issue Mar 14, 2015 · 7 comments
Closed

Added NFCIP support (NDEF) #10

GoogleCodeExporter opened this issue Mar 14, 2015 · 7 comments

Comments

@GoogleCodeExporter
Copy link

I added NFCIP support to libnfc. It is a messy patch, but it works (see
included initiator and target example apps). You need two readers to test
this. The initiator and target send each other a simple "Hello World/Mars"
message.

Issues with the patch:
- I copied some functions and added "dep" in their name when the PN53x
instruction is different, this could be optimized a bit by having some kind
of configuration somewhere to indicate that DEP / NFCIP is used
- NFCIP needs to activate the target, which is something else than
selecting it apparently (different command)

The patch is against latest svn (r71).



Original issue reported on code.google.com by fkooman%tuxed.net@gtempaccount.com on 22 Aug 2009 at 4:31

Attachments:

@GoogleCodeExporter
Copy link
Author

Updated patch. Somewhat cleaner now.

Original comment by fkooman%tuxed.net@gtempaccount.com on 28 Aug 2009 at 11:01

Attachments:

@GoogleCodeExporter
Copy link
Author

Hey,

Thanks for patches but could you add doxygen comments to document API ?
What does DEP means ?
Does it remain issues with libnfc-nfcip-reworked.patch ?

Original comment by romu...@libnfc.org on 2 Sep 2009 at 4:38

  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect

@GoogleCodeExporter
Copy link
Author

> Thanks for patches but could you add doxygen comments to document API ?

I will look into this soon :) Is there already a doxygen configuration file 
available
somewhere? 

> What does DEP means ?

Data Exchange Protocol. 

> Does it remain issues with libnfc-nfcip-reworked.patch ?

Yeah well. It is still a problem, nfc_target_send_dep_bytes and 
nfc_target_send_bytes
are basically the same (also true for receive), only a different PN53x command 
is
used. But in the send method there is no way to know what PN53x command to use. 
This
could of course be added to the tag_info struct, but that does not get passed 
to the
send/receive functions.

Any ideas on this? I was thinking about creating a send_differentiated / send  
and
send_dep function where they both call send_differentiated with a parameter
specifying which command is required. Aaarrgh C! :)

Original comment by fkooman%tuxed.net@gtempaccount.com on 2 Sep 2009 at 4:50

@GoogleCodeExporter
Copy link
Author

There are no Doxygen configuration file yet : use a default one.

I'll look at your issue regarding send/receive command is NFCIP mode next week.

Thanks again for this great contribution.

Original comment by romu...@libnfc.org on 2 Sep 2009 at 5:00

@GoogleCodeExporter
Copy link
Author

Now with comments in libnfc.h 

Original comment by fkooman%tuxed.net@gtempaccount.com on 2 Sep 2009 at 9:58

Attachments:

@GoogleCodeExporter
Copy link
Author

Applied as experimental feature in r89, thanks !

Original comment by romu...@libnfc.org on 3 Sep 2009 at 1:57

  • Changed title: Added NFCIP support (NDEF)

@GoogleCodeExporter
Copy link
Author

Original comment by romu...@libnfc.org on 3 Sep 2009 at 1:58

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant