[DEV-7540] Implement type guards for Title/Subtitle headings #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kudlajz
commented
Jun 6, 2023
| @@ -26,6 +33,22 @@ export namespace HeadingNode { | |||
| return ComposedElement.isComposedElement(value, type); | |||
| } | |||
|
|
|||
| export function isTitleHeadingNode<Heading extends HeadingNode<Child>, Child extends Node>( | |||
There was a problem hiding this comment.
Unfortunately I wasn't able to test it in the content renderer package, because linking the @prezly/story-content-format module worked, but it wouldn't resolve the underlying imports from @prezly/content-format 😕
There was a problem hiding this comment.
I've checked that the typeguards still worked, just wasn't able to compile it due to the mentioned import not being resolved.
e1himself
approved these changes
Jun 6, 2023
kudlajz
deleted the
feature/dev-7540-update-prezlycontent-renderer-react-js
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.