Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

수정: 로그인 예외 핸들링, 관리자 api 엔드 포인트 수정 #114

Merged
merged 9 commits into from
Oct 10, 2023

Conversation

Hejow
Copy link
Collaborator

@Hejow Hejow commented Oct 10, 2023

🔍 어떤 PR인가요?

  • 로그인 예외 핸들러를 수정했습니다.
  • 관리자 api의 엔드 포인트를 수정하고, swagger 코드를 형식에 맞게 수정했습니다.
  • 완료된 To-Do들을 지웠습니다.

😋 To Reviewer

  • 로그인 예외에 대해서 구체적으로 제공해주지 않습니다. 그에 맞게 수정했습니다.
  • api를 수정하면서 기존에 알맞는 위치가 아닌 코드들의 위치를 변경했습니다.

Copy link
Collaborator

@2jie0516 2jie0516 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당 !

*/
@ExceptionHandler(AuthenticationException.class)
@ExceptionHandler({BadCredentialsException.class, InternalAuthenticationServiceException.class})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍


import static com.devcourse.kurlymurly.web.order.AnswerOrderSupport.*;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@Hejow Hejow merged commit 268ae38 into main Oct 10, 2023
1 check passed
@Hejow Hejow deleted the feature-hejow branch October 10, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants