[NAYB-81] feat: 사용자와 연관된 데이터를 제거 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4-NaBMart into feature/NAYB-81
…4-NaBMart into feature/NAYB-150
`Order`와의 연관관계만 끊어주도록 변경하였음
사용자 삭제 시 `Order`삭제 및 빈번한 조회의 사유로 `Delivery` 엔티티에 관련 필드들을 추가하여 반정규화하였음
hseong3243
requested review from
pushedrumex,
funnysunny08,
seongHyun-Min,
Seongju-Lee and
bjo6300
as code owners
bjo6300
approved these changes
Sep 15, 2023
|
|
||
| public interface CartItemRepository extends JpaRepository<CartItem, Long> { | ||
|
|
||
| List<CartItem> findAllByCartItemIdOrderByCreatedAt(Long cartItemId); | ||
|
|
||
| List<CartItem> findAllByCartOrderByCreatedAt(Cart cart); | ||
|
|
||
| @Modifying |
There was a problem hiding this comment.
@Query를 사용할시 insert, update, delete 작업을 하기 위해 필요한 어노테이션입니다!
| properties.setProperty("REDIS_HOST", "localhost"); | ||
| properties.setProperty("REDIS_PORT", "6379"); | ||
| properties.setProperty("spring.data.redis.host", "localhost"); | ||
| properties.setProperty("spring.data.redis.port", "6379"); |
There was a problem hiding this comment.
Suggested change
| properties.setProperty("spring.data.redis.port", "6379"); | |
| properties.setProperty("REDIS_HOST", "localhost"); | |
| properties.setProperty("REDIS_PORT", "6379"); | |
| properties.setProperty("spring.data.redis.host", "localhost"); | |
| properties.setProperty("spring.data.redis.port", "6379"); |
REDIS_HOST, spring.data.redis.host 둘 다 필요한가요??
There was a problem hiding this comment.
해당 환경변수를 설정해주지 않으니 테스트가 안 돌아가서 추가해주었습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛏ 작업 사항
Delivery의 경우 라이더에게 중요한 데이터이기에 제거하지 않고 남겨두었습니다. 더하여 조회시 빈번한 조인이 일어나는Order의 일부 필드들을 반정규화 하였습니다.리뷰,찜 상품,장바구니,장바구니 상품,결제내역,주문,유저쿠폰,유저가 삭제됩니다.상품,카테고리,이벤트,쿠폰,라이더는 삭제되지 않습니다.배달은상품과의 연관관계를 끊고 주소 정보가 "삭제됨"이라는 텍스트로 대체됩니다.📝 작업 요약
Delivery반정규화(address, price, deliveryFee, riderRequest 추가)💡 관련 이슈