Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SonarCloud + GitAction 연동 작업 /#111 #114

Merged
merged 2 commits into from
Sep 22, 2023
Merged

SonarCloud + GitAction 연동 작업 /#111 #114

merged 2 commits into from
Sep 22, 2023

Conversation

jay-so
Copy link
Member

@jay-so jay-so commented Sep 21, 2023

👨‍💻 작업 사항

**이슈 #111 **

📑 PR 개요


✅ 작업 목록

  • SonarCloud 연결 설정 변경
  • GitActions 연동

기타


Prefix

PR 코멘트를 작성할 때 항상 Prefix를 붙여주세요.

  • P1: 꼭 반영해주세요 (Request changes)
  • P2: 적극적으로 고려해주세요 (Request changes)
  • P3: 웬만하면 반영해 주세요 (Comment)
  • P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
  • P5: 그냥 사소한 의견입니다 (Approve)

@jay-so jay-so added the dev-리팩토링 [refactor] 실행 결과는 동일하고, 코드 구조만 변경한다. label Sep 21, 2023
@jay-so jay-so added this to the 4차 스프린트 milestone Sep 21, 2023
@jay-so jay-so requested a review from a team September 21, 2023 17:11
@jay-so jay-so self-assigned this Sep 21, 2023
@jay-so jay-so requested review from charlesuu and Hchanghyeon and removed request for a team September 21, 2023 17:11
@jay-so jay-so linked an issue Sep 21, 2023 that may be closed by this pull request
2 tasks
@github-actions
Copy link

Test Results

16 files  ±0  16 suites  ±0   24s ⏱️ +4s
61 tests ±0  61 ✔️ ±0  0 💤 ±0  0 ±0 
69 runs  ±0  69 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 0e0bc06. ± Comparison against base commit 0d23c39.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.
com.programmers.ticketparis.reservation.repository.MybatisReservationRepositoryTest ‑ [1] reservation=com.programmers.ticketparis.reservation.domain.Reservation@49fa0fcb
com.programmers.ticketparis.reservation.repository.MybatisReservationRepositoryTest ‑ [2] reservation=com.programmers.ticketparis.reservation.domain.Reservation@99c866
com.programmers.ticketparis.reservation.service.ReservationServiceTest ‑ [1] reservationCreateRequest=com.programmers.ticketparis.reservation.dto.request.ReservationCreateRequest@29d77422
com.programmers.ticketparis.reservation.service.ReservationServiceTest ‑ [2] reservationCreateRequest=com.programmers.ticketparis.reservation.dto.request.ReservationCreateRequest@310831b7
com.programmers.ticketparis.reservation.repository.MybatisReservationRepositoryTest ‑ [1] reservation=com.programmers.ticketparis.reservation.domain.Reservation@60b59586
com.programmers.ticketparis.reservation.repository.MybatisReservationRepositoryTest ‑ [2] reservation=com.programmers.ticketparis.reservation.domain.Reservation@109115d1
com.programmers.ticketparis.reservation.service.ReservationServiceTest ‑ [1] reservationCreateRequest=com.programmers.ticketparis.reservation.dto.request.ReservationCreateRequest@edbf280
com.programmers.ticketparis.reservation.service.ReservationServiceTest ‑ [2] reservationCreateRequest=com.programmers.ticketparis.reservation.dto.request.ReservationCreateRequest@1f14ebc5

@github-actions
Copy link

Test Coverage Report

Overall Project 66.07% 🍏

There is no coverage information present for the Files changed

@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@Hchanghyeon Hchanghyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 재훈님~!

Approve 했습니다~!

👍👍👍

@jay-so jay-so merged commit 2289918 into develop Sep 22, 2023
5 checks passed
@jay-so jay-so deleted the feature/#111 branch September 22, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-리팩토링 [refactor] 실행 결과는 동일하고, 코드 구조만 변경한다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SonarCloud + GitAction 연동 작업
2 participants