Feature/#116 #117
Closed
Feature/#116 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay-so
added
the
dev-๋ฆฌํฉํ ๋ง
jay-so
requested review from
charlesuu and
Hchanghyeon
and removed request for
a team
Test Results0 filesโ โ-โ16โโ0 suitesโ โ-โ16โโโ0s โฑ๏ธ -21s Results for commit 2f2470d.โยฑ Comparison against base commit 0fb9b6e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐จโ๐ป ์์ ์ฌํญ
๐ PR ๊ฐ์
โ ์์ ๋ชฉ๋ก
(Swagger ํ์ผ ๋ด์์ SpringBoot์์ ์ ๊ณตํ๋ ApiResponse์ ์์ฑํ ApiResponsee ์ธ์ ์ถฉ๋์ด ๋์ด ๋ณ๊ฒฝํจ)
๊ธฐํ
Prefix
P1: ๊ผญ ๋ฐ์ํด์ฃผ์ธ์ (Request changes)P2: ์ ๊ทน์ ์ผ๋ก ๊ณ ๋ คํด์ฃผ์ธ์ (Request changes)P3: ์ฌ๋งํ๋ฉด ๋ฐ์ํด ์ฃผ์ธ์ (Comment)P4: ๋ฐ์ํด๋ ์ข๊ณ ๋์ด๊ฐ๋ ์ข์ต๋๋ค (Approve)P5: ๊ทธ๋ฅ ์ฌ์ํ ์๊ฒฌ์ ๋๋ค (Approve)