Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#121] README.md에 프로젝트 관련 내용 추가 #122

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

kylekim2123
Copy link
Member

👨‍💻 작업 사항

이슈 #121

📑 PR 개요

  • 프로젝트 마무리 단계에서의 README 내용 추가

✅ 작업 목록

  • README 업데이트

Prefix

PR 코멘트를 작성할 때 항상 Prefix를 붙여주세요.

  • P1: 꼭 반영해주세요 (Request changes)
  • P2: 적극적으로 고려해주세요 (Request changes)
  • P3: 웬만하면 반영해 주세요 (Comment)
  • P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
  • P5: 그냥 사소한 의견입니다 (Approve)

@kylekim2123 kylekim2123 added the dev-문서 [docs] .gitignore, README 등의 문서를 작성 및 수정한다. label Sep 25, 2023
@kylekim2123 kylekim2123 added this to the 4차 스프린트 milestone Sep 25, 2023
@kylekim2123 kylekim2123 self-assigned this Sep 25, 2023
@kylekim2123 kylekim2123 linked an issue Sep 25, 2023 that may be closed by this pull request
1 task
@github-actions
Copy link

Test Coverage Report

Overall Project 63.43% 🍏

There is no coverage information present for the Files changed

@github-actions
Copy link

Test Results

16 files  ±0  16 suites  ±0   20s ⏱️ -3s
61 tests ±0  61 ✔️ ±0  0 💤 ±0  0 ±0 
69 runs  ±0  69 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit ed290f3. ± Comparison against base commit 430fea5.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.
com.programmers.ticketparis.reservation.repository.MybatisReservationRepositoryTest ‑ [1] reservation=com.programmers.ticketparis.reservation.domain.Reservation@1a07a18c
com.programmers.ticketparis.reservation.repository.MybatisReservationRepositoryTest ‑ [2] reservation=com.programmers.ticketparis.reservation.domain.Reservation@6c9a4f34
com.programmers.ticketparis.reservation.service.ReservationServiceTest ‑ [1] reservationCreateRequest=com.programmers.ticketparis.reservation.dto.request.ReservationCreateRequest@6e008a27
com.programmers.ticketparis.reservation.service.ReservationServiceTest ‑ [2] reservationCreateRequest=com.programmers.ticketparis.reservation.dto.request.ReservationCreateRequest@52926d7f
com.programmers.ticketparis.reservation.repository.MybatisReservationRepositoryTest ‑ [1] reservation=com.programmers.ticketparis.reservation.domain.Reservation@16248b15
com.programmers.ticketparis.reservation.repository.MybatisReservationRepositoryTest ‑ [2] reservation=com.programmers.ticketparis.reservation.domain.Reservation@6a17dbdf
com.programmers.ticketparis.reservation.service.ReservationServiceTest ‑ [1] reservationCreateRequest=com.programmers.ticketparis.reservation.dto.request.ReservationCreateRequest@6aaf9e6b
com.programmers.ticketparis.reservation.service.ReservationServiceTest ‑ [2] reservationCreateRequest=com.programmers.ticketparis.reservation.dto.request.ReservationCreateRequest@ac30f10

@github-actions
Copy link

Test Coverage Report

Overall Project 63.43% 🍏

There is no coverage information present for the Files changed

@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@Hchanghyeon Hchanghyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

영주님 작성해주시느라 고생많으셨습니다!

감사합니다 🙇👍👍👍

@kylekim2123 kylekim2123 merged commit a7c7f7d into develop Sep 25, 2023
5 checks passed
@kylekim2123 kylekim2123 deleted the feature/#121 branch September 25, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-문서 [docs] .gitignore, README 등의 문서를 작성 및 수정한다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README.md에 프로젝트 관련 내용 추가
3 participants