[TI-67] 공통 응답용 API 추가 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0923kdh
reviewed
Oct 27, 2021
| public class CommonData { | ||
| private final String message; | ||
| private final String requestUri; | ||
| @JsonFormat(shape = JsonFormat.Shape.STRING, pattern = "yyyyMMddHHmmss", timezone = "Asia/Seoul") |
There was a problem hiding this comment.
@jsonformat(shape = JsonFormat.Shape.STRING, pattern = "yyyyMMddHHmmss") 로 하면 timezone utc가 디폴트로 알고있습니다! timezone 정책에 대해서 다 같이 이야기 나눠보면 좋겠습니다!
There was a problem hiding this comment.
저도 utc 타임존으로 하는게 어떤가 생각합니다!
There was a problem hiding this comment.
timezone을 넣어주나 빼주나 결과값이 같습니다.
나중에 한 번 다시 화인을 해 볼 필요가 있어 보입니다.
|
|
||
| @Getter | ||
| public class CommonData { | ||
| private final String message; |
sangmin7648
requested changes
Oct 27, 2021
Comment on lines
24
to
26
| public static <T> ApiResponse<T> fail(String failMessage, String requestUri, T data, Integer statusCode) { | ||
| CommonData common = new CommonData(failMessage, requestUri, statusCode); | ||
| return new ApiResponse<>(common, data); |
There was a problem hiding this comment.
statusCode에 Integer 대신에 HttpStatus enum을 사용해 보는건 어떤가요???
There was a problem hiding this comment.
확실히 그 편이 더 좋아보입니다.
실제 응답에서 숫자로 나가는지 문자로 나가는지 한 번 확인 해 볼 필요가 있음-> 문자로 나옴 -> 숫자로 나오도록 수정 (티켓 작성됨)
sangmin7648
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
공통 응답용 API
{ "common": { "message": "success", "requestUri": "/v1/users", "timestamp": "20211021212822", "internalHttpStatusCode": 200 }, "data": [] }