-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4기-김주웅] 1~2주차 과제 : 계산기 구현 미션 제출합니다. #161
Open
JuwoongKim
wants to merge
21
commits into
prgrms-be-devcourse:JuwoongKim
Choose a base branch
from
JuwoongKim:main
base: JuwoongKim
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jun 6, 2023
-
* Intellij를 사용해 Java Project 생성 * gitignore.io 를 통해 불필요한 파일 숨김 ( Intellij+all , gradle, java)
Configuration menu - View commit details
-
Copy full SHA for 07dd9d9 - Browse repository at this point
Copy the full SHA 07dd9d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5b44c0 - Browse repository at this point
Copy the full SHA c5b44c0View commit details -
* 기존 상황에서 org.junit.jupiter.params를 인식하지 못해 @ParameterizedTest를 사용할 수 없었음 todo : 정확한 원인을 확인해야함
Configuration menu - View commit details
-
Copy full SHA for 5350e4d - Browse repository at this point
Copy the full SHA 5350e4dView commit details
Commits on Jun 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e67619a - Browse repository at this point
Copy the full SHA e67619aView commit details -
* Calulator clas 에서 lombok으로 @AllArg... 생성하려 했으나, 오류남 -> 우선 코드로 직접 생성자를 작성하고 추후 변경 예정
Configuration menu - View commit details
-
Copy full SHA for 7bae5d1 - Browse repository at this point
Copy the full SHA 7bae5d1View commit details -
* validateExpression 메서드를 통해 구현함 * 함수 내부의 정규표현식을 사용해 검증 * trim 처리는 외부의 compute 메서드에서 진행 (다시 parsing해야하니깐)
Configuration menu - View commit details
-
Copy full SHA for 451492e - Browse repository at this point
Copy the full SHA 451492eView commit details -
feat : 연산 입력값 공백 전처리 기능 추가 및 테스트
* trim을 사용해 앞, 뒤 공백 제거 * 정규표현식을 사용해, 문자열 내부 공백을 한칸으로, 숫자사이는 공백없음으로 전처리
Configuration menu - View commit details
-
Copy full SHA for 9052efa - Browse repository at this point
Copy the full SHA 9052efaView commit details -
* 불변객체인 문자열을 계속 입력값으로 사용하는 것이 마음에 걸림 -> 메모리 낭비 * 문자열 배열로 변경
Configuration menu - View commit details
-
Copy full SHA for 5ac7699 - Browse repository at this point
Copy the full SHA 5ac7699View commit details -
Configuration menu - View commit details
-
Copy full SHA for a10e125 - Browse repository at this point
Copy the full SHA a10e125View commit details -
feat : 연산 입력 값 후위 표기식 변환 기능 추가 + parseExpression 입출력 타입변환
* 기존 배열 타입에서 크기 변경에 자유로운 리스트 형태로 변환 * 후위 표기식 변환 시 연산자 우선순위를 위해 사칙연산에 대한 enum 을 추가함
Configuration menu - View commit details
-
Copy full SHA for 6439421 - Browse repository at this point
Copy the full SHA 6439421View commit details -
* 후위식 표현식 리스트를 인자로 받아 우선순위에 맞게 사칙연산 구현 todo: 0으로 나눌 시 ArithmeticException 를 던지도록 하였지만, 처리부분을 작성하지 않음
Configuration menu - View commit details
-
Copy full SHA for b4ce338 - Browse repository at this point
Copy the full SHA b4ce338View commit details -
test : 0으로 나누어 발생하는 ArithmeticException 예외 테스트 코드 작성
* 예외 처리는 다른 부분과 함께 처리할 예정 ... 처리 범위 생각중
Configuration menu - View commit details
-
Copy full SHA for 76e52dd - Browse repository at this point
Copy the full SHA 76e52ddView commit details -
* 프로그램 수행 시 계산을 3번 정도 반복하다 보면, 입력을 받으면서 "Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0." waring 이 발생하며 종료됨 * 버전을 변경했지만, 9.0을 가리킴, 조사를 통해 intellij setting을 gradle(default)가 아닌 idea로 변경함 todo : 구현 완료 후 원인을 정확히 정리해야 함
Configuration menu - View commit details
-
Copy full SHA for e861350 - Browse repository at this point
Copy the full SHA e861350View commit details -
feat : 입출력을 BufferedReader로 변경
* 추가적인 문제로 Scanner 사용 시, 모드 선택 값을 받고 연산입력값을 받을 떄, 입력 값을 받지 않고, 그냥 넘어감 * gradle-wrapper버전변경, BufferedReader 사용 동 이것저것 변경하여 문제 현상이 발생하지 않지만, 원인을 다시 확인해야함
Configuration menu - View commit details
-
Copy full SHA for a23441b - Browse repository at this point
Copy the full SHA a23441bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c1928df - Browse repository at this point
Copy the full SHA c1928dfView commit details -
* 예외를 처리하는 범위를 Caculator 실행 전체 범위로 잡음 * 한 곳에서 예외를 처리해 보기가 쉽지만, 추후에 분리하여 처리해야함
Configuration menu - View commit details
-
Copy full SHA for 6a6bc9c - Browse repository at this point
Copy the full SHA 6a6bc9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fd1184 - Browse repository at this point
Copy the full SHA 2fd1184View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7f98cd - Browse repository at this point
Copy the full SHA b7f98cdView commit details -
* 네이버 캠퍼스 핵데이 Java 코딩 컨벤션을 따름 * https://naver.github.io/hackday-conventions-java/ * 인텔리제이에 해당 fomatter 적용 * https://bestinu.tistory.com/64
Configuration menu - View commit details
-
Copy full SHA for cff0639 - Browse repository at this point
Copy the full SHA cff0639View commit details
Commits on Jun 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6cac2df - Browse repository at this point
Copy the full SHA 6cac2dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 60b31aa - Browse repository at this point
Copy the full SHA 60b31aaView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.