Fix #28: correct width for wide columns #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repository owner
deleted a comment from
coveralls
Oct 7, 2018
Repository owner
deleted a comment from
coveralls
Oct 7, 2018
Repository owner
deleted a comment from
coveralls
Oct 7, 2018
Repository owner
deleted a comment from
coveralls
Oct 7, 2018
|
Thanks for the Pull Request. Can you just squash the 2 commits into a single one? Other than that this looks good to me. |
Add test_table_auto_width() that checks for a table to behave the same way if one column is wider than its equal share of max_width compared to when all columns stay below that, assuming max_width is large enough to accomodate the complete table. Adjust auto_calculate_width() to keep the actual width if it's smaller than the new one with adjusted share. This fixes issue #28 and passes the new test. I'm not sure why the flagging by equally shared width is used, so I left it in. This may be improvable with more insight into what the width adjustment is meant to solve.
|
Squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the bug that wide columns receive all the remaining width from
max_widthdescribed in issue #28. I am not sure why the columns are first flagged and than adjusted if their width exceeds the "fair share" of `max_width", so I left that code in. Maybe it's not needed and this could be solved by removing the lines but I suppose note.I also added a test to check if a table with a large
max_widthgives the same string length as table with a small (but sufficient)max_width.