Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

design: Carousel, ImageModal 디자인 수정 #256

Merged
merged 2 commits into from
Jan 9, 2024
Merged

design: Carousel, ImageModal 디자인 수정 #256

merged 2 commits into from
Jan 9, 2024

Conversation

shinhyojeong
Copy link
Member

🔗 이슈 번호

⛳ 구현 사항

  • Carousel 이미지 있는 경우엔 배경색 갖지 않도록
  • ImageModal DIM 고정하기

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 34cb4ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shinhyojeong shinhyojeong requested a review from a team January 9, 2024 07:04
@shinhyojeong shinhyojeong self-assigned this Jan 9, 2024
@shinhyojeong shinhyojeong added design 사용자 UI 디자인 변경 waiting Code Review Code Review 대기중 labels Jan 9, 2024
@shinhyojeong shinhyojeong changed the base branch from main to release/v0.3.2 January 9, 2024 07:08
sonsurim
sonsurim approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@sonsurim sonsurim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shinhyojeong shinhyojeong merged commit 1cb5d99 into release/v0.3.2 Jan 9, 2024
2 of 3 checks passed
@shinhyojeong shinhyojeong deleted the feat/#252_Carousel-ImageModal branch January 9, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonsurim sonsurim sonsurim approved these changes

Assignees

@shinhyojeong shinhyojeong

Labels
design 사용자 UI 디자인 변경 waiting Code Review Code Review 대기중
Projects
Offer FE
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Carousel, ImageModal 컴포넌트 개선
2 participants
@shinhyojeong @sonsurim