Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ImageModal, Carousel 수정 #269

Merged
merged 6 commits into from
Feb 1, 2024
Merged

fix: ImageModal, Carousel 수정 #269

merged 6 commits into from
Feb 1, 2024

Conversation

shinhyojeong
Copy link
Member

🔗 이슈 번호

⛳ 구현 사항

  • ImageModal 이미지 처음 위치 못잡는 이슈 수정
  • Carousel 이미지 클릭 화살표 클릭시엔 동작하지 않도록
  • ImageModal, Carousel src -> url로 타입 변경
  • Carousel tablet, mobile에서 동작하지 않는 이슈 수정

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2024

⚠️ No Changeset found

Latest commit: 8bed547

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shinhyojeong shinhyojeong self-assigned this Jan 31, 2024
@shinhyojeong shinhyojeong added fix 기능 관련 디버깅 waiting Code Review Code Review 대기중 labels Jan 31, 2024
sonsurim
sonsurim approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@sonsurim sonsurim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shinhyojeong shinhyojeong changed the base branch from main to release/v0.3.6 February 1, 2024 13:31
@shinhyojeong shinhyojeong merged commit 320c875 into release/v0.3.6 Feb 1, 2024
2 of 3 checks passed
@shinhyojeong shinhyojeong deleted the fix/#268_imageModal-carousel branch February 1, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonsurim sonsurim sonsurim approved these changes

Assignees

@shinhyojeong shinhyojeong

Labels
fix 기능 관련 디버깅 waiting Code Review Code Review 대기중
Projects
Offer FE
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: imageModal, Carousel 이슈 수정
2 participants
@shinhyojeong @sonsurim