Update Box ref prop

priceline · Jul 3, 2024 · d4bdf41 · d4bdf41
1 parent 5fd1f27
commit d4bdf41
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/packages/core/src/Absolute/Absolute.tsx b/packages/core/src/Absolute/Absolute.tsx
@@ -17,7 +17,7 @@ import { Box, BoxProps } from '../Box/Box'
 /**
  * @public
  */
-export type AbsoluteProps<T extends HTMLElement = HTMLDivElement> = BoxProps<T> &
+export type AbsoluteProps = BoxProps &
   TopProps &
   RightProps &
   BottomProps &

diff --git a/packages/core/src/Box/Box.tsx b/packages/core/src/Box/Box.tsx
@@ -1,4 +1,4 @@
-import React, { type ForwardedRef } from 'react'
+import React from 'react'
 import styled from 'styled-components'
 import {
   BorderRadiusProps,
@@ -38,7 +38,7 @@ import { applyVariations, color, colorScheme } from '../utils/utils'
 /**
  * @public
  */
-export type BoxProps<T extends HTMLElement = HTMLDivElement> = Omit<BorderRadiusProps, 'borderRadius'> &
+export type BoxProps = Omit<BorderRadiusProps, 'borderRadius'> &
   BoxShadowProps &
   DisplayProps &
   HeightProps &
@@ -51,7 +51,7 @@ export type BoxProps<T extends HTMLElement = HTMLDivElement> = Omit<BorderRadius
   SpaceProps &
   TextAlignProps &
   WidthProps &
-  React.HTMLAttributes<T> & {
+  React.ComponentPropsWithRef<'div'> & {
     children?: React.ReactNode
     as?: unknown
     role?: string
@@ -79,7 +79,6 @@ export type BoxProps<T extends HTMLElement = HTMLDivElement> = Omit<BorderRadius
       | 'background'
     colorScheme?: ColorSchemeName
     onClick?: React.ComponentProps<'div'>['onClick']
-    ref?: ForwardedRef<T>
     rounded?:
       | 'round'
       | 'top'

diff --git a/packages/core/src/Flex/Flex.tsx b/packages/core/src/Flex/Flex.tsx
@@ -20,7 +20,7 @@ import { applyVariations } from '../utils/utils'
 /**
  * @public
  */
-export type FlexProps<T extends HTMLElement = HTMLDivElement> = BoxProps<T> &
+export type FlexProps = BoxProps &
   SpaceProps &
   WidthProps &
   AlignItemsProps &

diff --git a/packages/core/src/Relative/Relative.tsx b/packages/core/src/Relative/Relative.tsx
@@ -17,12 +17,12 @@ import { Box, type BoxProps } from '../Box/Box'
 /**
  * @public
  */
-export type RelativeProps<T extends HTMLElement = HTMLDivElement> = TopProps &
+export type RelativeProps = TopProps &
   RightProps &
   BottomProps &
   LeftProps &
   ZIndexProps &
-  BoxProps<T>
+  BoxProps
 
 /**
  * @public