-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Core components written in TypeScript #970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8e5d158
to
235afac
Compare
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
craigpalermo
commented
Nov 29, 2020
f1a335b
to
77afeac
Compare
I have a SB6 branch as well, I don't think it warrants having open until SB gets that issue resolved. |
77afeac
to
86631bb
Compare
4491a89
to
a54249d
Compare
Blocked by the fix in #995 |
2a8b57a
to
16328e4
Compare
Upgrade to Storybook 6
16328e4
to
0944670
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included:
Box
component and related files in TypeScripttypes
projectTracking this issue related to prop table on docsite for TS components and this issue related to missing docs page props for styled components.
Todo
rush lint:fix
rush change
Box
, as well as JS components