Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Core components written in TypeScript #970

Closed
wants to merge 1 commit into from
Closed

Add support for Core components written in TypeScript #970

wants to merge 1 commit into from

Conversation

craigpalermo
Copy link
Collaborator

@craigpalermo craigpalermo commented Nov 25, 2020 •
edited
Loading

Changes included:

  • Rewrite Box component and related files in TypeScript
  • Update Storybook project to SB 6 for the built-in TS support. This also fixes the broken docs pages in the existing storybook.
  • Delete unused types project

Tracking this issue related to prop table on docsite for TS components and this issue related to missing docs page props for styled components.

Todo

  • Fix error in rush lint:fix
  • Run rush change
  • Confirm that prop types appear on Storybook Docs page for Box, as well as JS components

@craigpalermo craigpalermo added core Related to pcln-design-system project (core components) typescript labels Nov 25, 2020
@craigpalermo craigpalermo force-pushed the typescript-support branch 5 times, most recently from 8e5d158 to 235afac Compare November 29, 2020 04:37
@craigpalermo craigpalermo force-pushed the typescript-support branch 6 times, most recently from f1a335b to 77afeac Compare November 29, 2020 07:06
@craigpalermo craigpalermo mentioned this pull request Nov 29, 2020
Merged
1 task
@sdalonzo
Copy link
Collaborator

I have a SB6 branch as well, I don't think it warrants having open until SB gets that issue resolved.

@craigpalermo craigpalermo linked an issue Dec 2, 2020 that may be closed by this pull request
Configure ESLint to work with TypeScript #951
Open
@craigpalermo craigpalermo force-pushed the typescript-support branch 5 times, most recently from 4491a89 to a54249d Compare December 28, 2020 18:42
@craigpalermo craigpalermo mentioned this pull request Dec 28, 2020
Merged
@craigpalermo
Copy link
Collaborator Author

Blocked by the fix in #995

@craigpalermo craigpalermo force-pushed the typescript-support branch 2 times, most recently from 2a8b57a to 16328e4 Compare December 29, 2020 21:34
@craigpalermo craigpalermo mentioned this pull request Jan 6, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Related to pcln-design-system project (core components) typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure ESLint to work with TypeScript
2 participants
@craigpalermo @sdalonzo