Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename innerContentScroll prop to innerContentOverflow #1490

Merged
merged 2 commits into from
May 6, 2024

Conversation

pcln-james
Copy link
Contributor

I need similar behaviour to what is being done with the innerContentScroll prop but I need to set the overflow to hidden. I don't want to create a whole new prop just to control this behaviour in a slightly different way so I thought renaming the prop and setting the changing the default value from true to scroll should help with backwards compatibility. This obviously isn't perfect, if anyone is setting this prop to false their code will be hurt by this but as this is the default functionality and a new prop anyway I think this is safe but I am happy to change the version bump if people disagree.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.06%. Comparing base (b5311a0) to head (c1b248b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1490      +/-   ##
==========================================
+ Coverage   93.02%   93.06%   +0.03%     
==========================================
  Files         146      146              
  Lines       11040    11040              
  Branches      651      658       +7     
==========================================
+ Hits        10270    10274       +4     
+ Misses        751      741      -10     
- Partials       19       25       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sdalonzo sdalonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing a prop that we know is in use has to be a major or coordinated with all the teams using it

@pcln-james pcln-james merged commit 528ef5a into main May 6, 2024
11 checks passed
@pcln-james pcln-james deleted the rename-innerContentOverflow-prop branch May 6, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants