Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of a PlaceholderImage component to be used during development #554

Merged
merged 1 commit into from Sep 20, 2019

Conversation

tfquirk
Copy link
Collaborator

@tfquirk tfquirk commented Aug 12, 2019

Added PlaceholderImage to packages/src, as well as tests, and storybook. Doc for PlaceholderImage also created

@codecov-io
Copy link

codecov-io commented Aug 12, 2019

Codecov Report

Merging #554 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #554   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          55     56    +1     
  Lines         567    582   +15     
=====================================
+ Hits          567    582   +15
Impacted Files Coverage Δ
packages/core/src/PlaceholderImage.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2ad5c5...18e4309. Read the comment docs.

Copy link
Collaborator

@craigpalermo craigpalermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅LGTM!

Copy link
Collaborator

@BeniCheni BeniCheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: Thanks for your contributions.

@BeniCheni BeniCheni merged commit 74f54e7 into master Sep 20, 2019
@BeniCheni BeniCheni deleted the feature/Create-placeholderimage-component branch September 20, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants