Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 support #5 #18

Merged
merged 2 commits into from Aug 16, 2016
Merged

Python 3 support #5 #18

merged 2 commits into from Aug 16, 2016

Conversation

Liwink
Copy link
Contributor

@Liwink Liwink commented Aug 15, 2016

#5

py.test-3.5 all passed

$ py.test-3.5
============================================================ test session starts ============================================================
platform darwin -- Python 3.5.1, pytest-2.8.7, py-1.4.31, pluggy-0.3.1
rootdir: /Users/Liwink/projects/mongokat, inifile:
plugins: cov-2.2.1, html-1.10.0
collected 58 items

test_api.py ......
test_collection.py .
test_ensure_fields.py .
test_hooks.py ..
test_mongokit_api.py .s.............s..s.ss..s..sss.ssss...sssss..s
test_readme_sample.py .
test_shortnames.py .

=================================================== 39 passed, 19 skipped in 0.77 seconds ===================================================

py.test-2.7 all passed

$ py.test-2.7
============================================================ test session starts ============================================================
platform darwin -- Python 3.5.1, pytest-2.8.7, py-1.4.31, pluggy-0.3.1
rootdir: /Users/Liwink/projects/mongokat, inifile:
plugins: cov-2.2.1, html-1.10.0
collected 58 items

test_api.py ......
test_collection.py .
test_ensure_fields.py .
test_hooks.py ..
test_mongokit_api.py .s.............s..s.ss..s..sss.ssss...sssss..s
test_readme_sample.py .
test_shortnames.py .

=================================================== 39 passed, 19 skipped in 0.51 seconds ===================================================

@sylvinus
Copy link
Contributor

@Liwink thanks a lot for the PR!

It seems that py.test-2.7 is still using Python 3.5.1 though. Is that the case?

@Liwink
Copy link
Contributor Author

Liwink commented Aug 16, 2016

@sylvinus thanks!

Now it is using Python 2.7.10 ;)

$ py.test tests
============================================================ test session starts ============================================================
platform darwin -- Python 2.7.10 -- py-1.4.31 -- pytest-2.7.0
CircleCI total nodes: 1, this node index: 0
rootdir: /Users/Liwink/projects/mongokat, inifile:
plugins: circleci, cov, html
collected 58 items

tests/test_api.py ......
tests/test_collection.py .
tests/test_ensure_fields.py .
tests/test_hooks.py ..
tests/test_mongokit_api.py .s.............s..s.ss..s..sss.ssss...sssss..s
tests/test_readme_sample.py .
tests/test_shortnames.py .

=================================================== 39 passed, 19 skipped in 0.85 seconds ===================================================

@@ -641,7 +641,7 @@ def _encode_maxkey(name, dummy0, dummy1, dummy2):
}

if not PY3:
_ENCODERS[long] = _encode_long
_ENCODERS[int] = _encode_long
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change was probably not needed?

@sylvinus
Copy link
Contributor

Apart from my comment, everything looks good!

@sylvinus
Copy link
Contributor

I'm merging this and adding a couple fixes afterwards. Thanks a lot for this!

@sylvinus sylvinus merged commit 5541451 into pricingassistant:master Aug 16, 2016
@sylvinus sylvinus mentioned this pull request Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants