Fix deployment --allow-dirty issue

[cottinisimone]

The [build])https://drone-1.prima.it/primait/event_sourcing.rs/451/1/4) that failed because of dirty directory. The issue is that .cargo directory should be ignored

[MaeIsBad]

I would suggest you add a --allow-dirty flag instead

https://github.com/primait/umami/pull/1074

.cargo specifies a bunch of cargo, and it's a directory you want to commit to git

[cottinisimone]

I would suggest you add a --allow-dirty flag instead

primait/umami#1074

.cargo specifies a bunch of cargo, and it's a directory you want to commit to git

Why do you think you want to commit a directory of cached things? .cargo directory is just a bunch of downloaded crates..

I think that --allow-dirty isn't that good because if something changes though all the steps (like the format, or the compilation or whatever) that should be committed in the source code, and not directly published..

Am i missing something?

[MaeIsBad]

I think that --allow-dirty isn't that good because if something changes though all the steps (like the format, or the compilation or whatever) that should be committed in the source code, and not directly published..

I thought allow-dirty would commit the clean state of the repo, but I was wrong, my bad.

Why do you think you want to commit a directory of cached things? .cargo directory is just a bunch of downloaded crates..

it is not, that's only a thing in the prima specific rust CI, because we set CARGO_HOME there. Normally .cargo contains the cargo config(https://doc.rust-lang.org/cargo/reference/config.html)

[MaeIsBad]

I'm not gonna block this on figuring out the perfect solution, since this will be fixed once we migrate to GHA, but can we just add a comment?

[cottinisimone]

I think that --allow-dirty isn't that good because if something changes though all the steps (like the format, or the compilation or whatever) that should be committed in the source code, and not directly published..

I thought allow-dirty would commit the clean state of the repo, but I was wrong, my bad.

Why do you think you want to commit a directory of cached things? .cargo directory is just a bunch of downloaded crates..

it is not, that's only a thing in the prima specific rust CI, because we set CARGO_HOME there. Normally .cargo contains the cargo config(https://doc.rust-lang.org/cargo/reference/config.html)

I saw this issue: rust-lang/cargo#9398