implement registered service healthchecks #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sadlerap
force-pushed
the
registered-service-healthchecks
branch
5 times, most recently
from
ea2d231
to
06bb14e
Compare
filariow
requested changes
Jul 19, 2023
sadlerap
force-pushed
the
registered-service-healthchecks
branch
2 times, most recently
from
bc4b028
to
55626e7
Compare
dperaza4dustbit
requested changes
Jul 19, 2023
sadlerap
force-pushed
the
registered-service-healthchecks
branch
3 times, most recently
from
8c8aba5
to
a66cb7a
Compare
filariow
requested changes
Jul 21, 2023
This implements healthchecks for registered services. A few important notes: - The state of registered services now defaults in the CRD to the new state "Unknown", rather than "Available". If a healthcheck is undefined or removed, then the service immediately becomes available, which is in line with old behavior. However, if a healthcheck is defined, we don't want to transition it to "Available", since we haven't run the healthcheck yet. - A new field, "minutes", has been added to the healthcheck's container field. It represents how many minutes should be between each check. This is largely introduced for testing purposes, since the planned default of 5 minutes makes acceptance testing a pain. Its value is restricted from 1 to 60. - Healthchecks time out after thirty seconds. We need to have some kind of timeout mechanism, since providing users a way to run processes (even if their unpriviledged) has a potential for abuse. Hard-coding it to 30 seconds is fairly reasonable default, but we might want to revisit how we decide this in the future. Signed-off-by: Andy Sadler <ansadler@redhat.com>
sadlerap
force-pushed
the
registered-service-healthchecks
branch
from
a66cb7a
to
c08e720
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements healthchecks for registered services. A few important notes: