Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aggregate request metrics and bump version #29

Merged
merged 4 commits into from Jul 17, 2023
Merged

Add aggregate request metrics and bump version #29

merged 4 commits into from Jul 17, 2023

Conversation

mmanes
Copy link
Contributor

@mmanes mmanes commented Jul 11, 2023

Adds aggregate HTTP metrics.

Issue:

Capture of new prometheus output:

# HELP prime_mvc_all_errors_total Generated from Dropwizard metric import (metric=prime-mvc.all.errors, type=com.codahale.metrics.Meter)
# TYPE prime_mvc_all_errors_total counter
prime_mvc_all_errors_total 5.0
# HELP prime_mvc_all_requests Generated from Dropwizard metric import (metric=prime-mvc.all.requests, type=com.codahale.metrics.Timer)
# TYPE prime_mvc_all_requests summary
prime_mvc_all_requests{quantile="0.5",} 0.018341042000000002
prime_mvc_all_requests{quantile="0.75",} 0.022982875
prime_mvc_all_requests{quantile="0.95",} 0.026575375000000002
prime_mvc_all_requests{quantile="0.98",} 0.030771000000000003
prime_mvc_all_requests{quantile="0.99",} 0.047524667
prime_mvc_all_requests{quantile="0.999",} 0.09823404200000001
prime_mvc_all_requests_count 358.0

bhalsey
bhalsey approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@bhalsey bhalsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@mmanes mmanes marked this pull request as ready for review July 11, 2023 21:01
@mmanes mmanes requested a review from robotdan July 11, 2023 21:01
robotdan
robotdan approved these changes Jul 12, 2023
View reviewed changes
build.savant Outdated Show resolved Hide resolved
src/main/java/org/primeframework/mvc/action/DefaultActionMappingWorkflow.java Outdated Show resolved Hide resolved
@mmanes mmanes mentioned this pull request Jul 12, 2023
Closed
@mmanes mmanes merged commit 0318bd1 into master Jul 17, 2023
@mmanes mmanes deleted the mmanes/281-http-stats branch July 17, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhalsey bhalsey bhalsey approved these changes

@robotdan robotdan robotdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmanes @bhalsey @robotdan