Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #165

Merged
merged 32 commits into from
Nov 21, 2017
Merged

Addresses #165

merged 32 commits into from
Nov 21, 2017

Conversation

wanderer
Copy link
Member

No description provided.

wanderer added 17 commits November 10, 2017 13:36
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 455f5db on addresses into 543560c on master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 21, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 455f5db on addresses into 543560c on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling db06b3c on addresses into 543560c on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling db06b3c on addresses into 543560c on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ad6bbae on addresses into 543560c on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ad6bbae on addresses into 543560c on master.

Copy link
Member

@sdtsui sdtsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wanderer - here is a first pass, as changes come in live.

index.js Outdated
return this.tree.flush()
}

/**
* regirsters a container with the hypervisor
* @param {Class} Constructor - a Class for instantiating the container
* @param {*} args - any args that the contructor takes
* @param {interger} typeId - the container's type identification ID
* @param {Interger} typeId - the container's type identification ID
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'interger'

capsManager.js Outdated
}

/**
* Stores a capability persistantly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'persistently'

actor.js Outdated

module.exports = class Kernel {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this is called actor instead of kernel, should we update docs/any var names for consistency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, defaintly

actor.js Outdated

module.exports = class Kernel {
module.exports = class Actor {
/**
* the Kernel manages the varous message passing functions and provides
* an interface for the containers to use
* @param {Object} opts
* @param {Object} opts.id - the UUID of the Kernel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kernel->actor?

actor.js Outdated

module.exports = class Kernel {
module.exports = class Actor {
/**
* the Kernel manages the varous message passing functions and provides
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kernel->actor?

actor.js Outdated
startup () {
return this.container.onStartup()
}

/**
* run the kernels code with a given enviroment
* run the Actor with a given message
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

actor.js Outdated
}

generateNextId () {
_generateNextId () {
Copy link
Member

@sdtsui sdtsui Nov 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--- sorry, misread the assignment there. Please disregard. makes sense!

capsManager.js Outdated
@@ -0,0 +1,38 @@
module.exports = class CapsManager {
/**
* The caps manager manages perstantly stores the capabilities
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'persistently'

capsManager.js Outdated
}

/**
* gets a cap given it's key
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 622b558 on addresses into 543560c on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f6890c6 on addresses into 543560c on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5a462da on addresses into 543560c on master.

@sdtsui
Copy link
Member

sdtsui commented Nov 21, 2017

adding .gitignore w/ #169

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 67c9bed on addresses into 543560c on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 33a6e56 on addresses into 543560c on master.

wanderer added 2 commits November 21, 2017 18:31
Add .gitignore - testdb and node_modules
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5ad1e81 on addresses into 543560c on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5ad1e81 on addresses into 543560c on master.

@wanderer wanderer merged commit bbe8bfe into master Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants