-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addresses #165
Conversation
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
Signed-off-by: wanderer <mjbecze@gmail.com>
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wanderer - here is a first pass, as changes come in live.
index.js
Outdated
return this.tree.flush() | ||
} | ||
|
||
/** | ||
* regirsters a container with the hypervisor | ||
* @param {Class} Constructor - a Class for instantiating the container | ||
* @param {*} args - any args that the contructor takes | ||
* @param {interger} typeId - the container's type identification ID | ||
* @param {Interger} typeId - the container's type identification ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'interger'
capsManager.js
Outdated
} | ||
|
||
/** | ||
* Stores a capability persistantly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'persistently'
actor.js
Outdated
|
||
module.exports = class Kernel { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that this is called actor instead of kernel, should we update docs/any var names for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, defaintly
actor.js
Outdated
|
||
module.exports = class Kernel { | ||
module.exports = class Actor { | ||
/** | ||
* the Kernel manages the varous message passing functions and provides | ||
* an interface for the containers to use | ||
* @param {Object} opts | ||
* @param {Object} opts.id - the UUID of the Kernel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kernel->actor?
actor.js
Outdated
|
||
module.exports = class Kernel { | ||
module.exports = class Actor { | ||
/** | ||
* the Kernel manages the varous message passing functions and provides |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kernel->actor?
actor.js
Outdated
startup () { | ||
return this.container.onStartup() | ||
} | ||
|
||
/** | ||
* run the kernels code with a given enviroment | ||
* run the Actor with a given message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
actor.js
Outdated
} | ||
|
||
generateNextId () { | ||
_generateNextId () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--- sorry, misread the assignment there. Please disregard. makes sense!
capsManager.js
Outdated
@@ -0,0 +1,38 @@ | |||
module.exports = class CapsManager { | |||
/** | |||
* The caps manager manages perstantly stores the capabilities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'persistently'
capsManager.js
Outdated
} | ||
|
||
/** | ||
* gets a cap given it's key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its
adding |
Add .gitignore - testdb and node_modules
No description provided.