Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GChart: Double escaping JS after 6.0.19/6.1.1 #475

Closed
melloware opened this issue Aug 14, 2017 · 4 comments
Closed

GChart: Double escaping JS after 6.0.19/6.1.1 #475

melloware opened this issue Aug 14, 2017 · 4 comments
Assignees
@melloware
Labels
bug
Milestone
6.2.0

Comments

@melloware
Copy link
Member

From this post https://forum.primefaces.org/viewtopic.php?f=14&t=51344

The Javascript was being escaped in our renderder but PF has globaly changed WidgetBuilder .attr() method to automatically escape JS. So it was being escaped twice.
@melloware melloware self-assigned this Aug 14, 2017
@melloware melloware added the bug label Aug 14, 2017
@melloware melloware added this to the 6.2.0 milestone Aug 14, 2017
@melloware
Copy link
Member Author

Fixed with this commit: primefaces-extensions/primefaces-extensions@168d26d

@melloware
Copy link
Member Author

I created a SNAPSHOT if someone wants to test it.

https://oss.sonatype.org/content/repositories/snapshots/org/primefaces/extensions/primefaces-extensions/6.2-SNAPSHOT/

@csyperski
Copy link

The snapshot works with 6.1.4 of PF

@melloware
Copy link
Member Author

I just cut an Extensions 6.1.5 Elite release including this fix if you need it. Read here: https://forum.primefaces.org/viewtopic.php?f=14&t=52458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
bug
Projects
None yet
Milestone
6.2.0
Development

No branches or pull requests
2 participants
@melloware @csyperski