ClockPicker: TODO List

[melloware]

• Look through PR's and apply appropriate patches: https://github.com/weareoutman/clockpicker/pulls
• Theming (the component does not look right in dark themes)
• AM/ PM (the clock supports AM/PM mode but its not implemented yet)
• Styling (the fonts and styling are off)
• Replace Bootstrap classes with custom CSS classes
• Done button I have Localized as "Close" but it also does not look right and is not centered
• Button mode like we have for time and calendar (not working currently)
• Add client side callbacks like beforeShow
• Add Ajax events like change or ValueChange
• PrimeFaces.skinInput of the Input component.
• HTMLInputText Attributes and InputRenderer
• Register overlay scroll and resize listener to close the overlay if open
• enable() and disable() widget methods
• Test and enable working properly in Dialog

cc @jxmai @jepsar

Here is what ours currently looks like

[jepsar]

Does "styling" also means adding dark mode support? Do you want me to have a look at those?

[jepsar]

I'll have a look at the styling and some other issues.

[melloware]

Thank you @jepsar

[jepsar]

After including the correct CSS it looks much better.

Maybe we should add darkmode in a new issue.

[melloware]

Looks way better!

[jepsar]

Also because I added ui-widget to the popup 😁

[melloware]

@jepsar did you push a commit I don't see any changes?

[melloware]

I just did some more refactoring to make it a more standard PF input type component

[jepsar]

I think I'll just push my changes (I didn't yet) and improve later (things like theme variable colors and dark mode).

[melloware]

I will take the AM/PM issue and looking through the open PRs issues

[jxmai]

I checked out the AM/PM issue and open a PR: #1431. This one is slightly more complicated than 24 hour format since Locale involves. Please take a look and let's see what you think.

[melloware]

I enhanced AM/PM to be locale aware so if you use locale="es" you will see it use "a.m." instead of "AM" for English etc. Also fixed a few bugs in AM/PM handling and applied a few PR's I found

[jxmai]

I enhanced AM/PM to be locale aware so if you use locale="es" you will see it use "a.m." instead of "AM" for English etc. Also fixed a few bugs in AM/PM handling and applied a few PR's I found

Cool fix 😎 (especially I saw javascript patches applied e.g. 2740f7c#diff-385b773093d6e9c4719ea68e3f552e3251c06b65e87a60921fa78f0028c66a4dR122-R135) to enable different locale of AM / PM

[melloware]

Next i need to test one in a dialog and apply some AppendTo patches I think so the popup displays properly inside a dialog.

[melloware]

OK dialog support added the last thing is the theme support @jepsar is handling.

[jepsar]

I hope that I can find some time to fix it this weekend.