Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputPhone: Upgrade to v21.2.6+ #1533

Closed
melloware opened this issue Apr 23, 2024 · 8 comments · Fixed by #1550
Closed

InputPhone: Upgrade to v21.2.6+ #1533

melloware opened this issue Apr 23, 2024 · 8 comments · Fixed by #1550
Assignees
@NicolaIsotta
Labels
dependencies Any updates to a dependency file javascript Pull requests that update Javascript code
Milestone
14.0.1

Comments

@melloware
Copy link
Member

https://github.com/jackocnr/intl-tel-input/releases/tag/v21.2.6

Looks like he is still making lots of good changes and improvements.

cc @NicolaIsotta @jepsar
@melloware melloware added dependencies Any updates to a dependency file javascript Pull requests that update Javascript code labels Apr 23, 2024
@NicolaIsotta

This comment was marked as outdated.

Sign in to view
@melloware

This comment was marked as outdated.

Sign in to view
@melloware
Copy link
Member Author

Looks like 23.0 might cause some problems with how utils is loaded: https://github.com/jackocnr/intl-tel-input/releases/tag/v23.0.0

@NicolaIsotta
Copy link
Contributor

NicolaIsotta commented May 13, 2024 •
edited
Loading

Man's dropping updates at an insanely high rate, lol.
Maybe I can update to the latest v22 and then we can evaluate what to do after PFE 14.0.1?

@melloware
Copy link
Member Author

Good plan!

NicolaIsotta added a commit to NicolaIsotta/primefaces-extensions that referenced this issue May 13, 2024
@NicolaIsotta
update to inputphone v22.0.2 ( primefaces-extensions#1533 )
db110d3
NicolaIsotta added a commit to NicolaIsotta/primefaces-extensions that referenced this issue May 14, 2024
@NicolaIsotta
update to inputphone v22.0.2 ( primefaces-extensions#1533 )
ba458e1
@NicolaIsotta
Copy link
Contributor

NicolaIsotta commented May 15, 2024 •
edited
Loading

I'm currently testing the upgrade to v22.
countrySearch option has been removed, should I remove it from component attributes too or we should avoid breaking changes in minor releases?

@melloware
Copy link
Member Author

weird that that option was removed? Or is it just the default now to be able to search countries?

@melloware
Copy link
Member Author

Oh its just TRUE by default yeah you can remove it then.

NicolaIsotta added a commit to NicolaIsotta/primefaces-extensions that referenced this issue May 16, 2024
@NicolaIsotta
update to inputphone v22.0.2 ( primefaces-extensions#1533 )
a2806fb
NicolaIsotta added a commit to NicolaIsotta/primefaces-extensions that referenced this issue May 16, 2024
@NicolaIsotta
update to intl-tel-input v22.0.2 ( primefaces-extensions#1533 )
0293db3
github-merge-queue bot pushed a commit that referenced this issue May 16, 2024
@NicolaIsotta
update to intl-tel-input v22.0.2 ( #1533 ) (#1550)
454f2c4
@melloware melloware mentioned this issue May 16, 2024
Merged
@melloware melloware added this to the 14.0.1 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NicolaIsotta NicolaIsotta

Labels
dependencies Any updates to a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Milestone
14.0.1
Development

Successfully merging a pull request may close this issue.

InputPhone: update to intl-tel-input v22.0.2 ( #1533 ) NicolaIsotta/primefaces-extensions
2 participants
@melloware @NicolaIsotta