-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InputPhone: always submit complete E.164 number #1445
InputPhone: always submit complete E.164 number #1445
Conversation
What exactly is the full number? And what is the difference with the number that is posted currently? |
Check https://github.com/jackocnr/intl-tel-input#recommended-usage
The currently submitted value does not include the international dial code |
We just use |
Yeah, to keep the international prefix in the dropdown, but to have it in the submitted value. I'm not sure 'bout the attribute name. Maybe @melloware I targeted 13.X as it's not a breaking change, let me know if have to change to 14.X only |
13.x is fine. i am not sure about fullValue either maybe "rawValue" or "completeValue" ? |
I'm not sure whether to make this an option. Also, I think I just might want to make E.164 the default and allow users to convert from there (if needed). If currently incomplete numbers are returned in certain scenarios, that's a bug IMO. |
0ba91d5
to
0cd1403
Compare
|
core/src/main/java/org/primefaces/extensions/component/inputphone/InputPhoneRenderer.java
Show resolved
Hide resolved
Is this PR ready? |
I would like to test this. Maybe I can do it today. |
This reverts commit f51c9a7.
@NicolaIsotta thanks for your fix! |
fixes #1393
marking it as draft as I still have to test CSP