Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents a TypeError from being thrown. #1587

Merged

Conversation

seklmco
Copy link
Contributor

@seklmco seklmco commented Jun 18, 2024

A TypeError is being thrown after setting autoRowSize: true using the updateSettings function:

$hot.updateSettings({
    autoRowSize: true,
});

The col parameter ends up being -1 causing this error to be thrown in the browser console:

sheet.js.xhtml?ln=primefaces-extensions&v=13.0.8&e=13.0.8:2092  Uncaught TypeError: Cannot read properties of undefined (reading 'type')
    at m.cells (sheet.js.xhtml?ln=primefaces-extensions&v=13.0.8&e=13.0.8:2092:60)
    at h.default.getCellMeta (sheet.js.xhtml?ln=primefaces-extensions&v=13.0.8&e=13.0.8:395:129)
    at h.default._getColWidthFromSettings (sheet.js.xhtml?ln=primefaces-extensions&v=13.0.8&e=13.0.8:401:139)
    at getColWidth (sheet.js.xhtml?ln=primefaces-extensions&v=13.0.8&e=13.0.8:401:392)
    at f.value (sheet.js.xhtml?ln=primefaces-extensions&v=13.0.8&e=13.0.8:575:311)
    at f.value (sheet.js.xhtml?ln=primefaces-extensions&v=13.0.8&e=13.0.8:575:462)
    at e.value (sheet.js.xhtml?ln=primefaces-extensions&v=13.0.8&e=13.0.8:428:168)
    at e.value (sheet.js.xhtml?ln=primefaces-extensions&v=13.0.8&e=13.0.8:424:217)
    at e.value (sheet.js.xhtml?ln=primefaces-extensions&v=13.0.8&e=13.0.8:421:303)
    at G.value (sheet.js.xhtml?ln=primefaces-extensions&v=13.0.8&e=13.0.8:1282:335)

@melloware melloware added this to the 13.0.12 milestone Jun 18, 2024
@melloware melloware added the defect Something isn't working label Jun 18, 2024
@melloware
Copy link
Member

Thanks for the PR!

@melloware melloware added this pull request to the merge queue Jun 18, 2024
Merged via the queue into primefaces-extensions:master with commit bacd6de Jun 18, 2024
2 checks passed
@seklmco
Copy link
Contributor Author

seklmco commented Jun 18, 2024

You are welcome!

@melloware
Copy link
Member

I backported this to 13.0.12 release as well.

@seklmco
Copy link
Contributor Author

seklmco commented Jun 18, 2024

Thanks, I appreciate that!

@seklmco
Copy link
Contributor Author

seklmco commented Jun 18, 2024

I am unfamiliar with the process of updating the repo here and how it affects the repo on Maven. How long does it take for the update to take effect there (not rushing if this is a manual effort).

@melloware
Copy link
Member

It's a manual effort. I will push 13.0.12 tomorrow.

@seklmco
Copy link
Contributor Author

seklmco commented Jun 18, 2024

Thank you :)

@melloware
Copy link
Member

13.0.12 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants