#2838

src/main/java/org/primefaces/component/autoupdate/AutoUpdateListener.java

@@ -0,0 +1,55 @@
+/**
+ * Copyright 2009-2017 PrimeTek.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.primefaces.component.autoupdate;
+
+import java.util.ArrayList;
+import javax.faces.component.UIComponent;
+import javax.faces.context.FacesContext;
+import javax.faces.event.AbortProcessingException;
+import javax.faces.event.ComponentSystemEvent;
+import javax.faces.event.ComponentSystemEventListener;
+
+/**
+ * Registers components to auto update
+ */
+public class AutoUpdateListener implements ComponentSystemEventListener {
+
+    private static final String COMPONENTS = AutoUpdateListener.class.getName() + ".COMPONENTS";
+
+    @Override
+    public void processEvent(ComponentSystemEvent cse) throws AbortProcessingException {
+        FacesContext context = FacesContext.getCurrentInstance();
+        String clientId = ((UIComponent) cse.getSource()).getClientId(context);
+
+        ArrayList<String> clientIds = getOrCreateAutoUpdateComponentClientIds(context);
+        if (!clientIds.contains(clientId)) {
+            clientIds.add(clientId);
+        }
+    }
+
+    public static ArrayList<String> getOrCreateAutoUpdateComponentClientIds(FacesContext context) {
+        ArrayList<String> clientIds = getAutoUpdateComponentClientIds(context);
+        if (clientIds == null) {
+            clientIds = new ArrayList<String>();
+            context.getViewRoot().getAttributes().put(COMPONENTS, clientIds);
+        }
+        return clientIds;
+    }
+
+    public static ArrayList<String> getAutoUpdateComponentClientIds(FacesContext context) {
+        return (ArrayList<String>) context.getViewRoot().getAttributes().get(COMPONENTS);
+    }
+}

src/main/java/org/primefaces/util/AutoUpdateComponentPhaseListener.java → src/main/java/org/primefaces/component/autoupdate/AutoUpdatePhaseListener.java

@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.primefaces.util;
+package org.primefaces.component.autoupdate;
 
 import java.util.ArrayList;
 import javax.faces.context.FacesContext;
@@ -22,7 +22,7 @@
 import javax.faces.event.PhaseListener;
 import org.primefaces.context.RequestContext;
 
-public class AutoUpdateComponentPhaseListener implements PhaseListener {
+public class AutoUpdatePhaseListener implements PhaseListener {
 
     @Override
     public void afterPhase(PhaseEvent event) {
@@ -32,11 +32,11 @@ public void afterPhase(PhaseEvent event) {
     @Override
     public void beforePhase(PhaseEvent event) {
         FacesContext context = event.getFacesContext();
-        if (RequestContext.getCurrentInstance(context).isIgnoreAutoUpdate()) {
+        if (!context.isPostback() || RequestContext.getCurrentInstance(context).isIgnoreAutoUpdate()) {
             return;
         }
 
-        ArrayList<String> clientIds = AutoUpdateComponentListener.getAutoUpdateComponentClientIds(context);
+        ArrayList<String> clientIds = AutoUpdateListener.getAutoUpdateComponentClientIds(context);
         if (clientIds != null && !clientIds.isEmpty()) {
             for (int i = 0; i < clientIds.size(); i++) {
                 String clientId = clientIds.get(i);

src/main/java/org/primefaces/component/autoupdate/AutoUpdateTagHandler.java

@@ -0,0 +1,48 @@
+/**
+ * Copyright 2009-2017 PrimeTek.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.primefaces.component.autoupdate;
+
+import java.io.IOException;
+import javax.el.ELException;
+import javax.faces.FacesException;
+import javax.faces.component.UIComponent;
+import javax.faces.event.PostAddToViewEvent;
+import javax.faces.event.PreRenderComponentEvent;
+import javax.faces.view.facelets.FaceletContext;
+import javax.faces.view.facelets.FaceletException;
+import javax.faces.view.facelets.TagConfig;
+import javax.faces.view.facelets.TagHandler;
+
+public class AutoUpdateTagHandler extends TagHandler {
+
+    private static final AutoUpdateListener LISTENER = new AutoUpdateListener();
+
+    public AutoUpdateTagHandler(TagConfig tagConfig) {
+        super(tagConfig);
+    }
+
+    @Override
+    public void apply(FaceletContext faceletContext, UIComponent parent) throws IOException, FacesException, FaceletException, ELException {
+        // PostAddToViewEvent should work for stateless views
+        //                  but fails for MyFaces ViewPooling
+        //                  and sometimes on postbacks as PostAddToViewEvent should actually ony be called once
+        parent.subscribeToEvent(PostAddToViewEvent.class, LISTENER);
+
+        // PreRenderComponentEvent should work for normal cases and MyFaces ViewPooling
+        //                      but likely fails for stateless view as we save the clientIds in the viewRoot
+        parent.subscribeToEvent(PreRenderComponentEvent.class, LISTENER);
+    }
+}

src/main/java/org/primefaces/component/fragment/FragmentRenderer.java

@@ -34,10 +34,6 @@ public void encodeBegin(FacesContext context, UIComponent component) throws IOEx
         Map<Object, Object> attrs = RequestContext.getCurrentInstance(context).getAttributes();
         attrs.put(Constants.FRAGMENT_ID, clientId);
 
-        if (fragment.isAutoUpdate()) {
-            attrs.put(Constants.FRAGMENT_AUTO_RENDERED, true);
-        }
-
         writer.startElement("div", component);
         writer.writeAttribute("id", clientId, "id");
     }

src/main/java/org/primefaces/context/RequestContext.java

@@ -21,7 +21,6 @@
 import javax.faces.application.FacesMessage;
 import javax.faces.context.FacesContext;
 
-import org.primefaces.component.api.AutoUpdatable;
 import org.primefaces.util.AjaxRequestBuilder;
 import org.primefaces.util.CSVBuilder;
 import org.primefaces.util.StringEncrypter;

src/main/java/org/primefaces/util/AjaxRequestBuilder.java

@@ -356,10 +356,6 @@ private void addFragmentConfig() {
         Object fragmentId = attrs.get(Constants.FRAGMENT_ID);
         if (fragmentId != null) {
             buffer.append(",fi:\"").append(fragmentId).append("\"");
-
-            if (attrs.containsKey(Constants.FRAGMENT_AUTO_RENDERED)) {
-                buffer.append(",fu:true");
-            }
         }
     }
 }

src/main/java/org/primefaces/util/Constants.java

@@ -72,7 +72,6 @@ public static class RequestParams {
     public static final String BARCODE_MAPPING = "primefaces.barcodeMapping";
 
     public final static String FRAGMENT_ID = "primefaces.fragment";
-    public final static String FRAGMENT_AUTO_RENDERED = "primefaces.fragment.autorendered";
 
     public static class DIALOG_FRAMEWORK {