Fix #11700: Widgets with trigger/target bind for removal

primefaces · Apr 10, 2024 · 70f9335 · 70f9335
1 parent ac30e44
commit 70f9335
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 22 deletions.
diff --git a/primefaces/src/main/resources/META-INF/resources/primefaces/dragdrop/dragdrop.js b/primefaces/src/main/resources/META-INF/resources/primefaces/dragdrop/dragdrop.js
@@ -107,12 +107,6 @@ PrimeFaces.widget.Droppable = PrimeFaces.widget.BaseWidget.extend({
         this.bindDropListener();
 
         this.jqTarget.droppable(this.cfg);
-
-        this.addDestroyListener(function() {
-            if ($this.jqTarget.length) {
-                $this.jqTarget.droppable('destroy');
-            }
-        });
     },
 
     /**

diff --git a/primefaces/src/main/resources/META-INF/resources/primefaces/resizable/resizable.js b/primefaces/src/main/resources/META-INF/resources/primefaces/resizable/resizable.js
@@ -70,9 +70,9 @@ PrimeFaces.widget.Resizable = PrimeFaces.widget.BaseWidget.extend({
             if (container) {
                 var $container = $(container);
                 if ($container.length) {
-                    var $this = this;
+                    var _self = this;
                     PrimeFaces.addDeferredRender(this.id, $container.attr('id'), function() {
-                        return $this.render();
+                        return _self.render();
                     });
                 }
             }
@@ -106,36 +106,30 @@ PrimeFaces.widget.Resizable = PrimeFaces.widget.BaseWidget.extend({
         	this.cfg.containment = PrimeFaces.escapeClientId(this.cfg.parentComponentId);
         }
 
-        var $this = this;
+        var _self = this;
 
         this.cfg.stop = function(event, ui) {
-            if($this.cfg.onStop) {
-                $this.cfg.onStop.call($this, event, ui);
+            if(_self.cfg.onStop) {
+                _self.cfg.onStop.call(_self, event, ui);
             }
 
-            $this.fireAjaxResizeEvent(event, ui);
+            _self.fireAjaxResizeEvent(event, ui);
         };
 
         this.cfg.start = function(event, ui) {
-            if($this.cfg.onStart) {
-                $this.cfg.onStart.call($this, event, ui);
+            if(_self.cfg.onStart) {
+                _self.cfg.onStart.call(_self, event, ui);
             }
         };
 
         this.cfg.resize = function(event, ui) {
-            if($this.cfg.onResize) {
-                $this.cfg.onResize.call($this, event, ui);
+            if(_self.cfg.onResize) {
+                _self.cfg.onResize.call(_self, event, ui);
             }
         };
 
         this.jqTarget.resizable(this.cfg);
 
-        this.addDestroyListener(function() {
-            if ($this.jqTarget.length) {
-                $this.jqTarget.resizable('destroy');
-            }
-        });
-
         this.removeScriptElement(this.id);
     },