Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable: set default filter either on UIColumn#filterValue or custom facet value #10067

Closed
Rapster opened this issue Apr 26, 2023 · 0 comments
Assignees
Labels
enhancement Additional functionality to current component question
Milestone

Comments

@Rapster
Copy link
Member

Rapster commented Apr 26, 2023

Description

Based on this: #9349 (comment)

In regards to when or when not to utilize the filterValue attribute...I was under the impression that the attribute was to be used if a filter was not explicitly defined in a filter facet via <f:facet name="filter">. Or in other words, the filterValue attribute was to be ignored if I did define a filter facet.

As there are two potential ways to define default value, users are confused which one to used, but more recently users tend to use custom facet filter value due to a "regression"

My solution is here #9349 (comment)

So, maybe the best way to go about it is to support both by simply doing a coalesce 😄 I can propose a fix, but maybe in another issue, your issue is pretty clear as to what is not working /confusing

Describe the solution you would like

support both UIColumn#filterValue and custom facet value, UIColumn#filterValue being priority number 1

Additional context

No response

@Rapster Rapster added enhancement Additional functionality to current component question labels Apr 26, 2023
Rapster added a commit to Rapster/primefaces that referenced this issue Apr 26, 2023
@Rapster Rapster self-assigned this May 2, 2023
@tandraschko tandraschko added this to the 13.0.0 milestone May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Additional functionality to current component question
Projects
None yet
Development

No branches or pull requests

2 participants