Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SplitButton: RowSelect of TreeTable is triggered #10157

Closed
fanste opened this issue May 22, 2023 · 1 comment · Fixed by #10159
Closed

SplitButton: RowSelect of TreeTable is triggered #10157

fanste opened this issue May 22, 2023 · 1 comment · Fixed by #10159
Assignees
@melloware
Labels
🐞 defect Bug...Something isn't working
Milestone
13.0.0

Comments

@fanste
Copy link
Contributor

fanste commented May 22, 2023

Describe the bug

SplitButtonRenderer#encodeMenuIcon has hardcoded style classes for the menu icon which is missing ui-c.

I did not find any reference on why this marker style class was introduced, but it seems to be used by the tree table to exclude span elements from triggering the row selection feature.

Maybe use HTML.BUTTON_LEFT_ICON_CLASS?

Reproducer

No response

Expected behavior

No response

PrimeFaces edition

Community

PrimeFaces version

master

Theme

No response

JSF implementation

Mojarra

JSF version

2.2

Java version

8

Browser(s)

No response
@fanste fanste added ‼️ needs-triage Issue needs triaging 🐞 defect Bug...Something isn't working labels May 22, 2023
melloware added a commit to melloware/primefaces that referenced this issue May 22, 2023
@melloware
Fix primefaces#10157: Splitbutton proper icon CSS
f4c5b88
@melloware melloware removed the ‼️ needs-triage Issue needs triaging label May 22, 2023
@melloware melloware mentioned this issue May 22, 2023
Merged
@melloware melloware added this to the 13.0.0 milestone May 22, 2023
@melloware melloware self-assigned this May 22, 2023
@melloware
Copy link
Member

Yep agreed!

melloware added a commit that referenced this issue May 22, 2023
@melloware
Fix #10157: Splitbutton proper icon CSS (#10159)
530d081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
🐞 defect Bug...Something isn't working
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

Fix #10157: Splitbutton proper icon CSS melloware/primefaces
2 participants
@fanste @melloware