DefaultMenuItem: Id gets overwritten

[LuleJayjay]

in BaseMenuRenderer encodeEnd a UniqueId is being generated for every MenuElement of the MenuModel.
If an ID was set before, it gets overwritten.

[kukel]

This is not a bug but as designed. Use a DynamicMenuModel if you want to assign ids yourself. Just keep in mind thatyou need to set them everywhere, also submenu's and groups

[LuleJayjay]

Did you even try it with DynamicMenuModel?
It doesn't work either!!
Please post an answer you really tried before posting.

[LuleJayjay]

To make the problem clearer:

if you set a String as the ID it gets still overwritten, because it needs an Integer later on:

BaseMenuRenderer PF 5.3.5 jar

protected MenuItem findMenuitem(List elements, String id) {
if(elements == null || elements.isEmpty()) {
return null;
}
else {
String[] paths = id.split(SEPARATOR);

        if(paths.length == 0)
            return null;

        int childIndex = Integer.parseInt(paths[0]);
        if(childIndex >= elements.size()) 
            return null;

        MenuElement childElement = elements.get(childIndex);

        if(paths.length == 1) {
            return (MenuItem) childElement;
        }
        else {
            String relativeIndex = id.substring(id.indexOf(SEPARATOR) + 1);

            return findMenuitem(((MenuGroup) childElement).getElements(), relativeIndex);
        }
    }
}

So why is it possible at all to set a String value as an ID?

[LuleJayjay]

another Problem is, that it is not possible to see any Ids of the MenuItems in the jsf. So no JavaScript actions possible. Something is totally wrong with ids and menuItems

[kukel]

I tried... and (by 'accident') used 'integers'... Lucky me...

[Dougnlizt]

Bit by this again (using PF 6.1). Sure would be helpful if this could be fixed. I'm not off to code a work-around...

[LuleJayjay]

I can post and explain my workaround tomorrow. it's not much effort.

[LuleJayjay]

I posted and explained my workaround over here now:

https://stackoverflow.com/questions/29427893/primefaces-how-to-dynamically-add-a-contextmenu-to-a-menuitem/34859269#34859269

hope it helps

[melloware]

So I am confused. I just read that whole stack overflow and this bug ticket and here is what I think I got out of it.

1. It doesn't work at all.
2. It works if you use integers instead of strings for the id.
3. DefaultMenuModel ID's overwritten is by design use DynamicMenuModel
4. DynamicMenuModel does not work either.

Couldn't the code be modified to check if a MenuItem had an ID already if it is doesn't then it would generate a unique one?

[LuleJayjay]

But that's exacty what I did. I overwrote the MenuRenderer and explained how to do it. look at "Lule"s Code example

[melloware]

So why not submit a PR if you have the issue fixed?

[LuleJayjay]

how can I do this?

[melloware]

https://help.github.com/articles/creating-a-pull-request/

[LuleJayjay]

aaah thank you. Will do that in the evening then.

[liptga]

@LuleJayjay which evening? Your PR would be appreciated by me as well :)

[melloware]

I just submitted a PR for this. It was quite an easy fix can @LuleJayjay @kukel please review.