Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PickList: fire 'change' event #11540

Closed
BalusC opened this issue Feb 29, 2024 · 1 comment · Fixed by #11543
Closed

PickList: fire 'change' event #11540

BalusC opened this issue Feb 29, 2024 · 1 comment · Fixed by #11543
Assignees
@melloware
Labels
enhancement Additional functionality to current component
Milestone
14.0.0

Comments

@BalusC
Copy link

BalusC commented Feb 29, 2024 •
edited

Description

<p:pickList> doesn't fire any change event when an item is transferred.

Describe the solution you would like

One way would be to add to fireTransferEvent function in picklist.js:

this.targetInput.trigger("change");
// and probably also this.sourceInput.trigger("change")?

Additional context

This way we can safely reuse existing global form/input change event listeners on them.
@BalusC BalusC added ‼️ needs-triage Issue needs triaging new feature labels Feb 29, 2024
melloware added a commit to melloware/primefaces that referenced this issue Feb 29, 2024
@melloware
Fix primefaces#11540: Picklist trigger input changes on transfer
3d3d702
@melloware melloware removed the ‼️ needs-triage Issue needs triaging label Feb 29, 2024
@melloware melloware mentioned this issue Feb 29, 2024
Merged
@melloware melloware added enhancement Additional functionality to current component and removed new feature labels Feb 29, 2024
@melloware melloware added this to the 14.0.0 milestone Feb 29, 2024
@melloware melloware self-assigned this Feb 29, 2024
melloware added a commit to melloware/primefaces that referenced this issue Mar 1, 2024
@melloware
Fix primefaces#11540: Picklist trigger input changes on transfer
82fd5ca
melloware added a commit to melloware/primefaces that referenced this issue Mar 1, 2024
@melloware
Fix primefaces#11540: Picklist trigger input changes on transfer
bcd954f
melloware added a commit that referenced this issue Mar 4, 2024
@melloware @jepsar
Fix #11540: Picklist trigger input changes on transfer (#11543)
c4ed952 
* Fix #11540: Picklist trigger input changes on transfer

* Update primefaces/src/main/resources/META-INF/resources/primefaces/picklist/picklist.js

* Fix #11540: Picklist trigger input changes on transfer

* Fix #11540: Picklist trigger input changes on transfer

---------

Co-authored-by: Jasper de Vries <jepsar@gmail.com>
@BalusC
Copy link
Author

BalusC commented Mar 5, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
enhancement Additional functionality to current component
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

Fix #11540: Picklist trigger input changes on transfer melloware/primefaces
2 participants
@BalusC @melloware