Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OverlayPanel: Memory Leak on destroy #11993

Closed
melloware opened this issue May 23, 2024 · 1 comment
Closed

OverlayPanel: Memory Leak on destroy #11993

melloware opened this issue May 23, 2024 · 1 comment
Assignees
@melloware
Labels
Resolution: Invalid Issue or pull request is not valid in the latest version

Comments

@melloware
Copy link
Member

Describe the bug

Currently when an overlay widget is cleaned up it calls jq.remove() to remove its contents from the DOM which is good.

However, if you have say a DataTable inside the overlay which has lots of .data() jquery items it leaves it all as detached elements in the DOM when you destroy the overlay.

Reproducer

No response

Expected behavior

When destroying and overlay panel there should be no detached DOM elements.

PrimeFaces edition

Community

PrimeFaces version

14.0.0

Theme

No response

JSF implementation

All

JSF version

2.3

Java version

11

Browser(s)

No response
@melloware melloware added 🐞 defect Bug...Something isn't working ‼️ needs-triage Issue needs triaging ⚡ performance Performance related issue or enhancement and removed 🐞 defect Bug...Something isn't working ‼️ needs-triage Issue needs triaging labels May 23, 2024
@melloware melloware added this to the 14.0.1 milestone May 23, 2024
@melloware melloware self-assigned this May 23, 2024
melloware added a commit to melloware/primefaces that referenced this issue May 23, 2024
@melloware
Fix primefaces#11993: OverlayPanel cleanup DOM
3162a63
melloware added a commit to melloware/primefaces that referenced this issue May 23, 2024
@melloware
Fix primefaces#11993: 14.0.1 OverlayPanel cleanup DOM
af6a648
This was referenced May 23, 2024
Closed
Closed
@melloware
Copy link
Member Author

The real issue is: #11994

@melloware melloware closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2024
@melloware melloware removed this from the 14.0.1 milestone May 23, 2024
@melloware melloware added Resolution: Invalid Issue or pull request is not valid in the latest version and removed ⚡ performance Performance related issue or enhancement labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Resolution: Invalid Issue or pull request is not valid in the latest version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #11993: OverlayPanel cleanup DOM melloware/primefaces
1 participant
@melloware