Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextEditor doesn't detect change of contents #12131

Closed
mertsincan opened this issue Jun 17, 2024 · 2 comments · Fixed by #12135
Closed

TextEditor doesn't detect change of contents #12131

mertsincan opened this issue Jun 17, 2024 · 2 comments · Fixed by #12135
Assignees
Labels
13.0.11 🐞 defect Bug...Something isn't working
Milestone

Comments

@mertsincan
Copy link
Member

Reported by PRO User;

The goal : If a machine.domain.tld is inserted into the TextEditor without a "https://" prefix, automatically insert one.
After having used the Quill editor API to modify a Delta containing the text, the tag's href shows the updated value. However, if the page is saved, the valueChangeListener can be used to view the TextEditor's before and after values. They are the same.
The attached .xhtml has a JS function replaceLink( url ) the updates the editor's Deltas.
Set a breakpoint in the attached controller's onHTMLChanged( ValueChangeEvent vce ) method. ...

@mertsincan mertsincan added 🐞 defect Bug...Something isn't working 13.0.11 labels Jun 17, 2024
@mertsincan mertsincan added this to the 15.0.0 milestone Jun 17, 2024
@mertsincan mertsincan self-assigned this Jun 17, 2024
melloware added a commit to melloware/primefaces that referenced this issue Jun 17, 2024
@melloware melloware modified the milestones: 15.0.0, 14.0.2 Jun 17, 2024
@melloware
Copy link
Member

@mertsincan this is causing two integration tests to fail. I am investigating.

@melloware
Copy link
Member

melloware commented Jun 17, 2024

@mertsincan just submitted this PR: #12135

I don't have their original test case but i am pretty sure source === 'api' so right now on every keystroke of a user the change is firing which is too much. So this changes it to only fire if its a NON user input.

https://quilljs.com/docs/api#text-change

can you check with what the PRO user is doing the value of source ? I am hoping its NOT user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
13.0.11 🐞 defect Bug...Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants