Provide more details in the error message for unimplemented methods in LazyDataModel

[andrei-ivanov]

getRowData and getRowKey need to be implemented in some (documented) cases, but these cases were enforced only sometime later.
As we didn't notice this aspect from the documentation, we still get exceptions in the logs.
With a large code base, it's difficult to find the source so I think it would be nice to get the viewId and component id in the exception message.

[tandraschko]

Feel free to provide a PR.

[andrei-ivanov]

Pff, cannot make the PF I've built from master work :-(

TypeError: $N.selector is undefined
$.fn.layout/_initContainer@https://localhost:8443/enss/javax.faces.resource/layout/layout.js.jsf?ln=primefaces&v=6.1-SNAPSHOT:1801:3
$.fn.layout/_create@https://localhost:8443/enss/javax.faces.resource/layout/layout.js.jsf?ln=primefaces&v=6.1-SNAPSHOT:1518:3
$.fn.layout@https://localhost:8443/enss/javax.faces.resource/layout/layout.js.jsf?ln=primefaces&v=6.1-SNAPSHOT:5083:6
PrimeFaces.widget.Layout<._render@https://localhost:8443/enss/javax.faces.resource/layout/layout.js.jsf?ln=primefaces&v=6.1-SNAPSHOT:5978:23
PrimeFaces.widget.DeferredWidget<.renderDeferred@https://localhost:8443/enss/javax.faces.resource/core.js.jsf?ln=primefaces&v=6.1-SNAPSHOT:1991:13
PrimeFaces.widget.Layout<.init@https://localhost:8443/enss/javax.faces.resource/layout/layout.js.jsf?ln=primefaces&v=6.1-SNAPSHOT:5957:9
Class.extend/prototype[name]</<@https://localhost:8443/enss/javax.faces.resource/core.js.jsf?ln=primefaces&v=6.1-SNAPSHOT:1898:23
Class@https://localhost:8443/enss/javax.faces.resource/core.js.jsf?ln=primefaces&v=6.1-SNAPSHOT:1911:9
PrimeFaces.createWidget@https://localhost:8443/enss/javax.faces.resource/core.js.jsf?ln=primefaces&v=6.1-SNAPSHOT:302:47
PrimeFaces.cw@https://localhost:8443/enss/javax.faces.resource/core.js.jsf?ln=primefaces&v=6.1-SNAPSHOT:287:13
@https://localhost:8443/enss/settings/UserDetails.jsf:28:14
resolve/</mightThrow@https://localhost:8443/enss/javax.faces.resource/jquery/jquery.js.jsf?ln=primefaces&v=6.1-SNAPSHOT:3508:21
resolve/</process<@https://localhost:8443/enss/javax.faces.resource/jquery/jquery.js.jsf?ln=primefaces&v=6.1-SNAPSHOT:3576:12

https://localhost:8443/enss/javax.faces.resource/layout/layout.js.jsf?ln=primefaces&v=6.1-SNAPSHOT
Line 1801

Built with mvn clean install.
Tried with -Prelease, but it fails to build with some JS parsing errors.

[tandraschko]

we currently upgraded jquery.js for testing. Should work fine if you rollback.

[andrei-ivanov]

Can I request for this to be included in 6.0.4 too? :-)
@mertsincan ?

[andrei-ivanov]

@mertsincan Will you please merge this for 6.0.5?

[andrei-ivanov]

@mertsincan this too please :)

[andrei-ivanov]

@mertsincan I'm not giving up :D

[andrei-ivanov]

@mertsincan ping :)

[andrei-ivanov]

@mertsincan missed 6.0.5 :(
6.0.6 please?

[mertsincan]

Hi @andrei-ivanov,
Sorry for my late reply. Fixed for 6.0.6.

[andrei-ivanov]

@mertsincan Thank you, I can stop bugging you now :-D