Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the DOM structure of selectItems on SelectOneListbox #3258

Closed
mertsincan opened this issue Jan 30, 2018 · 2 comments
Closed

Improve the DOM structure of selectItems on SelectOneListbox #3258

mertsincan opened this issue Jan 30, 2018 · 2 comments
Assignees
@mertsincan
Labels
6.1.13 enhancement Additional functionality to current component
Milestone
6.2

Comments

@mertsincan
Copy link
Member

No description provided.

@mertsincan mertsincan added enhancement Additional functionality to current component 6.1.13 labels Jan 30, 2018
@mertsincan mertsincan added this to the 6.2 milestone Jan 30, 2018
@mertsincan mertsincan self-assigned this Jan 30, 2018
@kukel
Copy link
Contributor

kukel commented Jan 30, 2018

Please document this very carefully since it might (for some users) break backwards compatibility

@mertsincan
Copy link
Member Author

mertsincan commented Jan 31, 2018 •
edited
Loading

Thanks a lot for your comment, but I don't think it'll break backward compatibility. I added only tag into < li > item tag and it doesn't have any CSS style.

Old code;
<li>Omega</li>

New code;
<li><span>Omega</span></li>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

Labels
6.1.13 enhancement Additional functionality to current component
Projects
None yet
Milestone
6.2
Development

No branches or pull requests
2 participants
@kukel @mertsincan