Datatable: sorting doesn't update header checkbox when checkAllToggler used

[martin654]

1) Environment

• PrimeFaces version: 6.2.6
• Does it work on the newest released PrimeFaces version? Version? 6.2.6 NO
• Does it work on the newest sources in GitHub? (Build by source -> https://github.com/primefaces/primefaces/wiki/Building-From-Source) Not working on 6.3-SNAPSHOT
• Application server + version:
• Affected browsers: all

I have a p:datatable component with
<p:column selectionMode="multiple" style="width:16px;text-align:center"/>
Some rows has their's checkbox disabled using expression in disabledSelection.
I use pagination, so there are pages where no row can be selected.
I also use sorting on some columns.

2) Expected behavior

When all of the row's checkboxes on current page are disabled on page load, then the header checkbox for toggleAll is disabled. When I use sorting and some of the rows are replaced with rows which are NOT disabled, then the toggleAll checkbox should be updated and become ENABLED.

3) Actual behavior

When all of the row's checkboxes on current page are disabled on page load, then the header checkbox for toggleAll is disabled. When I use sorting and some of the rows are replaced with rows which are NOT disabled, then the toggleAll checkbox is NOT enabled.

4) Steps to reproduce

Will provide if necessary. Fix is simple.

5) Sample XHTML

Will provide if necessary. Fix is simple.

6) Sample bean

Will provide if necessary. Fix is simple.

[martin654]

Fixed here: martin654@e7445de

Created pull request: #3920

[martin654]

@tandraschko Thomas, could this be merged into next elite version? Thank you

[tandraschko]

i don't manage elite releases, thats up to @mertsincan

[martin654]

Ok, I see... How do you manage pull requests? Should I do something more to get the fix it into master?

[tandraschko]

PRs are for the community version
PrimeTek merges selected PRs then into the private elite branches

[tandraschko]

@mertsincan Would you merge it to elite?

[mertsincan]

Thanks a lot, @tandraschko and @martin654 ;)