Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid CSS: add offset #4217

Closed
NicolaIsotta opened this issue Nov 7, 2018 · 3 comments
Closed

Grid CSS: add offset #4217

NicolaIsotta opened this issue Nov 7, 2018 · 3 comments
Assignees
Milestone

Comments

@NicolaIsotta
Copy link
Contributor

1) Environment

2) Expected behavior

With the commit primefaces/primeng@ba14090 (which closed primefaces/primeng#3362 ), offset classes were added to the "new" grid CSS. It would be nice if the changes could be ported to primefaces too.

NB: primefaces/primeng#5144 changes could be ported too

@tandraschko
Copy link
Member

@mertsincan Are there any plans to port it?

@melloware
Copy link
Member

+1 on this.

mertsincan added a commit that referenced this issue Nov 22, 2018
Fix #4217: Grid CSS updates from PrimeNG.
@mertsincan mertsincan self-assigned this Nov 22, 2018
@mertsincan mertsincan added this to the 6.3 milestone Nov 22, 2018
mertsincan added a commit that referenced this issue Nov 22, 2018
@melloware
Copy link
Member

Attaching this sample here to prove everything is working.
pf-grid.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants