Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme: CSS is loaded without version #6083

Closed
melloware opened this issue Jun 25, 2020 · 2 comments · Fixed by #6498
Closed

Theme: CSS is loaded without version #6083

melloware opened this issue Jun 25, 2020 · 2 comments · Fixed by #6498
Assignees
@melloware
Labels
enhancement Additional functionality to current component
Milestone
10.0.0

Comments

@melloware
Copy link
Member

Description
PrimeFaces theme.css is loaded in HeadRenderer but does not append the version so its causing the browser to not refresh the cache on PF updates.

<link type="text/css" rel="stylesheet" 
         href="/primefaces-test/javax.faces.resource/theme.css.xhtml?ln=primefaces-omega" />

Describe the solution you would like
The version to be appended to the theme.css resource.

<link type="text/css" rel="stylesheet" 
         href="/primefaces-test/javax.faces.resource/theme.css.xhtml?ln=primefaces-omega&amp;v=8.0"" />

Additional context
The bug is in PrimeResource only looking for ln=primefaces exactly and not "startsWith" primefaces because the themes are ln=primefaces-omega etc.
@melloware melloware added the enhancement Additional functionality to current component label Jun 25, 2020
melloware added a commit to melloware/primefaces that referenced this issue Jun 25, 2020
@melloware
Fix primefaces#6083: Add version to theme.css URL
3c7a83f
@melloware melloware self-assigned this Jun 25, 2020
@melloware melloware added this to the 9.0 milestone Jun 25, 2020
@melloware melloware linked a pull request Jun 25, 2020 that will close this issue
Fix #6083: Add version to theme.css URL #6084
Merged
melloware added a commit to melloware/primefaces that referenced this issue Jun 25, 2020
@melloware
Fix primefaces#6083: Add version to theme.css URL
a436523
mertsincan added a commit that referenced this issue Jun 29, 2020
@mertsincan
Merge pull request #6084 from melloware/PF6083
7f3ab1c 
Fix #6083: Add version to theme.css URL
mertsincan added a commit that referenced this issue Jun 29, 2020
@mertsincan
Revert "Fix #6083: Add version to theme.css URL"
124ec5b
mertsincan added a commit that referenced this issue Jun 29, 2020
@mertsincan
Merge pull request #6092 from primefaces/revert-6084-PF6083
981c3e2 
Revert "Fix #6083: Add version to theme.css URL"
@mertsincan mertsincan reopened this Jun 29, 2020
@melloware melloware mentioned this issue Oct 11, 2020
Closed
@tandraschko
Copy link
Member

any news here @melloware ?

@melloware
Copy link
Member Author

No I was going to resubmit my PR. My PRO ticket is still open.

@melloware melloware removed a link to a pull request Nov 10, 2020
Fix #6083: Add version to theme.css URL #6084
Merged
@melloware melloware linked a pull request Nov 10, 2020 that will close this issue
Fix #6083: Add version to theme.css URL #6498
Merged
melloware added a commit to melloware/primefaces that referenced this issue Nov 16, 2020
@melloware
Fix primefaces#6083: Add version to theme.css URL
60a52b9
tandraschko added a commit that referenced this issue Nov 16, 2020
@tandraschko
Merge pull request #6498 from melloware/PF-6083
9c62081 
Fix #6083: Add version to theme.css URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
enhancement Additional functionality to current component
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Fix #6083: Add version to theme.css URL melloware/primefaces
3 participants
@tandraschko @melloware @mertsincan